Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Use the filesystem from the object cache when unmounting / mounting filesystems. #1978

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

johnsonw
Copy link
Contributor

@johnsonw johnsonw commented Jun 17, 2020

Use the filesystem from the object cache when unmounting / mounting filesystems.

Signed-off-by: johnsonw wjohnson@whamcloud.com


This change is Reviewable

filesystems.

Signed-off-by: johnsonw <wjohnson@whamcloud.com>
@johnsonw johnsonw added this to the IML EX V2 milestone Jun 17, 2020
@johnsonw johnsonw requested a review from jgrund June 17, 2020 16:37
"host": self.host,
"filesystems": [
(
ObjectCache.get_one(ManagedFilesystem, lambda mf, mtd=m: mf.name == mtd.filesystem).mount_path(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference comparing to the above two lines (search= and unmounted=)?

Copy link
Contributor Author

@johnsonw johnsonw Jun 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unmounted is a list of unmount LustreClientMount objects. We loop through each of these and match on the filesystem whose name in the umounted client mount objects matches the filesystem name. That will then give a list of filesystems that correspond to the mounts. For example, say we have:

Filesystems:
fs1, fs2, and fs3.

Mounts:
mnt1, mnt2

mnt1 is associated with fs1
mnt2 is associated with fs2

We unmount both of these instances but their object still exists. We then later want to mount them. The expression would return a list with:
[fs1 mount path, fs2 mount path]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem i'm working through at the moment is that the mount path is erased when a client is unmounted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That can (should) be in a separate patch.

@jgrund jgrund merged commit a625ee5 into master Jun 17, 2020
@jgrund jgrund deleted the fix-unmount-client branch June 17, 2020 19:10
jgrund pushed a commit that referenced this pull request Jun 20, 2020
…1978)

filesystems.

Signed-off-by: johnsonw <wjohnson@whamcloud.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants