This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Update influxdb healthcheck #1986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a lower resource check.
Fixes #1984.
Signed-off-by: Joe Grund <jgrund@whamcloud.io>
johnsonw
approved these changes
Jun 18, 2020
ip1981
approved these changes
Jun 18, 2020
utopiabound
reviewed
Jun 18, 2020
| @@ -33,9 +33,9 @@ services: | |||
| - influxdb:/var/lib/influxdb/ | |||
| - "manager-config:/var/lib/chroma" | |||
| healthcheck: | |||
| test: ["CMD-SHELL", "influx -host influxdb -execute 'show databases'"] | |||
| test: ["CMD-SHELL", "curl --fail influxdb:8086/ping?wait_for_leader=10s"] | |||
There was a problem hiding this comment.
This can also just use influx -host influxdb -execute 'exit' instead. It's what's used during setup to wait for influx to be online.
There was a problem hiding this comment.
Looks like that takes ~ 50% of a core:
Keep in mind this is being run every 5s.
jgrund
added a commit
that referenced
this pull request
Jun 20, 2020
Use a lower resource check.
Fixes #1984.
Signed-off-by: Joe Grund <jgrund@whamcloud.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a lower resource check.
Fixes #1984.
Signed-off-by: Joe Grund jgrund@whamcloud.io
This change is