This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Make favicons dynamic #1988
Merged
Make favicons dynamic #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsonw
force-pushed
the
dynamic-favicon
branch
from
ff86f2a
to
503d0e5
Compare
johnsonw
force-pushed
the
dynamic-favicon
branch
from
503d0e5
to
588f7b9
Compare
johnsonw
force-pushed
the
dynamic-favicon
branch
from
ab2f4bd
to
d10117b
Compare
ip1981
reviewed
Jun 20, 2020
ip1981
reviewed
Jun 20, 2020
johnsonw
force-pushed
the
iml-config-cli
branch
2 times, most recently
from
d082469
to
b49f700
Compare
johnsonw
force-pushed
the
dynamic-favicon
branch
from
d10117b
to
2dc7e20
Compare
johnsonw
force-pushed
the
dynamic-favicon
branch
from
10e3cc1
to
36177de
Compare
|
Can you rebase this on latest master? It has changes from the previous patch. |
johnsonw
force-pushed
the
dynamic-favicon
branch
from
c03eaad
to
a0f0d57
Compare
jgrund
suggested changes
Jun 23, 2020
jgrund
reviewed
Jun 23, 2020
johnsonw
force-pushed
the
dynamic-favicon
branch
from
3fc0215
to
72073f7
Compare
jgrund
reviewed
Jun 23, 2020
|
Rpm Branding: Docker Branding: |
Create an iml-config cli tool that will be used to perform config related tasks. In this patch, a drop-in will be added to nginx that will load all iml environment variables. These environment variables will then be used to generate the nginx config file from the chroma template any time nginx is restarted. This will allow the template variables to change in the nginx config based on environment variable overloading. Signed-off-by: johnsonw <wjohnson@whamcloud.com>
johnsonw
force-pushed
the
dynamic-favicon
branch
from
173c259
to
f76a164
Compare
jgrund
reviewed
Jun 24, 2020
jgrund
approved these changes
Jun 25, 2020
ip1981
approved these changes
Jun 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make favicons dynamic
Fixes #1700.
Signed-off-by: johnsonw wjohnson@whamcloud.com
This change is