This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Fix user disconnects #2006
Merged
Fix user disconnects #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ip1981
previously approved these changes
Jun 23, 2020
johnsonw
previously approved these changes
Jun 23, 2020
In: https://github.com/whamcloud/integrated-manager-for-lustre/blob/83d065653a55ee4c1a6068c1d024f02a02c73172/iml-warp-drive/src/users.rs#L54-L58 We spawn a task to disconnect users. However, we move both the tx and rx handles into the task and block on the tx being cancelled. Due to this approach, we will not disconnect users and instead buffer their handles. Instead, we should use .retain when sending to users and remove the ones that error. Signed-off-by: Joe Grund <jgrund@whamcloud.io>
ip1981
approved these changes
Jun 24, 2020
ip1981
approved these changes
Jun 25, 2020
johnsonw
approved these changes
Jun 25, 2020
jgrund
added a commit
that referenced
this pull request
Jun 29, 2020
In: https://github.com/whamcloud/integrated-manager-for-lustre/blob/83d065653a55ee4c1a6068c1d024f02a02c73172/iml-warp-drive/src/users.rs#L54-L58 We spawn a task to disconnect users. However, we move both the tx and rx handles into the task and block on the tx being cancelled. Due to this approach, we will not disconnect users and instead buffer their handles. Instead, we should use .retain when sending to users and remove the ones that error. Signed-off-by: Joe Grund <jgrund@whamcloud.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In:
integrated-manager-for-lustre/iml-warp-drive/src/users.rs
Lines 54 to 58 in 83d0656
We spawn a task to disconnect users. However, we move both the tx and rx
handles into the task and block on the tx being cancelled.
Due to this approach, we will not disconnect users and instead buffer
their handles.
Instead, we should use .retain when sending to users and remove the ones
that error.
Signed-off-by: Joe Grund jgrund@whamcloud.io
This change is