This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Snapshot graph #2023
Merged
Snapshot graph #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsonw
force-pushed
the
snapshot-graph
branch
12 times, most recently
from
0f7641c
to
9edda53
Compare
johnsonw
force-pushed
the
snapshot-graph
branch
4 times, most recently
from
b1a1a78
to
58861f5
Compare
jgrund
previously approved these changes
Jul 10, 2020
Comment on lines
+18
to
+25
| let config: Config = Config::default(); | ||
| let config: Config = Config { | ||
| profile_map: vec![("base_monitored".into(), config.storage_servers())], | ||
| test_type: TestType::Docker, | ||
| ntp_server: NtpServer::HostOnly, | ||
| fs_type: FsType::ZFS, | ||
| ..config | ||
| }; |
There was a problem hiding this comment.
nit
Suggested change
| let config: Config = Config::default(); | |
| let config: Config = Config { | |
| profile_map: vec![("base_monitored".into(), config.storage_servers())], | |
| test_type: TestType::Docker, | |
| ntp_server: NtpServer::HostOnly, | |
| fs_type: FsType::ZFS, | |
| ..config | |
| }; | |
| let config: Config = Config { | |
| profile_map: vec![("base_monitored".into(), config.storage_servers())], | |
| test_type: TestType::Docker, | |
| ntp_server: NtpServer::HostOnly, | |
| fs_type: FsType::ZFS, | |
| ..Config::default() | |
| }; |
There was a problem hiding this comment.
sure, want me to change it to all of the test files in a follow up patch or would you prefer the change in this patch?
ntp should be stopped before invoking sntp and waiting for synchronization. Signed-off-by: johnsonw <wjohnson@whamcloud.com>
- Add snapshots Signed-off-by: johnsonw <wjohnson@whamcloud.com>
jgrund
approved these changes
Jul 13, 2020
beevans
pushed a commit
to beevans/integrated-manager-for-lustre
that referenced
this pull request
Aug 6, 2020
* Update wait on ntp ntp should be stopped before invoking sntp and waiting for synchronization. Signed-off-by: johnsonw <wjohnson@whamcloud.com> * Add snapshots - Add snapshots Signed-off-by: johnsonw <wjohnson@whamcloud.com> * updates Signed-off-by: johnsonw <wjohnson@whamcloud.com> Co-authored-by: Joe Grund <jgrund@whamcloud.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add snapshot graph
This change is