Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Fix OST pool grow #2064

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Fix OST pool grow #2064

merged 1 commit into from
Jul 13, 2020

Conversation

ip1981
Copy link
Member

@ip1981 ip1981 commented Jul 10, 2020

Different types of sets were compared to each other:
objects and strings:

current set([<ManagedOst: fs-OST0000>]),
new set([u'fs-OST0000', u'fs-OST0001']),
add set([u'fs-OST0000', u'fs-OST0001']),
remove set([<ManagedOst: fs-OST0000>]).

Make sure to compare strings only.

There is a minor and likely unrelated issue when growing with the same OST: an empty job list results in an error:

[root@adm ~]# vim /var/log/chroma/job_scheduler.log
[root@adm ~]# iml filesystem pool grow fs fast fs-OST0002
Growing ost pool...
[1/1]   ✔ Updating OST Pool successful
[root@adm ~]# iml filesystem pool grow fs fast fs-OST0001
Growing ost pool...
✗ HTTP status client error (404 Not Found) for url (https://adm.local/api/ostpool/4/)
[root@adm ~]# iml filesystem pool show fs fast
+------------+------------+
| Filesystem | fs         |
+------------+------------+
| Name       | fast       |
+------------+------------+
| OSTs       | fs-OST0000 |
|            | fs-OST0001 |
|            | fs-OST0002 |
+------------+------------+
[root@adm ~]# 

Closes #1852 and probably #1853:

chroma=> select * from chroma_core_ostpool;
 id | name | not_deleted | content_type_id | filesystem_id 
----+------+-------------+-----------------+---------------
  1 | fast |             |              44 |             1
  2 | fast |             |              44 |             1
  3 | fast |             |              44 |             1
  4 | fast | t           |              44 |             1
(4 filas)

chroma=> select * from chroma_core_ostpool_osts;
 id | ostpool_id | managedost_id 
----+------------+---------------
 17 |          4 |            10
 18 |          4 |            12
 19 |          4 |            13

Signed-off-by: Igor Pashev pashev.igor@gmail.com


This change is Reviewable

Different types of sets were compared to each other:
objects and strings:

    current set([<ManagedOst: fs-OST0000>]),
    new set([u'fs-OST0000', u'fs-OST0001']),
    add set([u'fs-OST0000', u'fs-OST0001']),
    remove set([<ManagedOst: fs-OST0000>]).

Make sure to compare strings only.

Signed-off-by: Igor Pashev <pashev.igor@gmail.com>
@ip1981 ip1981 added the bug label Jul 10, 2020
@ip1981 ip1981 requested a review from a team July 10, 2020 18:02
@ip1981 ip1981 self-assigned this Jul 10, 2020
@ip1981 ip1981 marked this pull request as ready for review July 10, 2020 18:53
@ip1981 ip1981 linked an issue Jul 13, 2020 that may be closed by this pull request
Copy link
Member

@jgrund jgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, waiting on full test run pass

@jgrund jgrund merged commit 28ad158 into master Jul 13, 2020
@jgrund jgrund deleted the ip1981/1852-grow branch July 13, 2020 17:24
beevans pushed a commit to beevans/integrated-manager-for-lustre that referenced this pull request Aug 6, 2020
Different types of sets were compared to each other:
objects and strings:

    current set([<ManagedOst: fs-OST0000>]),
    new set([u'fs-OST0000', u'fs-OST0001']),
    add set([u'fs-OST0000', u'fs-OST0001']),
    remove set([<ManagedOst: fs-OST0000>]).

Make sure to compare strings only.

Signed-off-by: Igor Pashev <pashev.igor@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSTs cannot be added to ostpools Cannot grow ostpool twice
3 participants