This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Make docker image tarball a required file #2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`iml-images.tgz` currently lives under /var/tmp and is marked as ok if it's missing. This can cause an issue if the tarball is removed, as `iml-docker` will not be able to load the images and startup. Move the tarball to `/var/lib`, and make it non-optional. Signed-off-by: Joe Grund <jgrund@whamcloud.io>
utopiabound
previously requested changes
Jul 23, 2020
iml-docker.spec
Outdated
| mv iml-cli-proxy.sh %{buildroot}%{_bindir}/iml | ||
| mv update-embedded.sh %{buildroot}%{_bindir}/update-embedded | ||
| mv iml-docker.service %{buildroot}%{_unitdir} | ||
|
|
||
|
|
||
| %files | ||
| %{_sysconfdir}/iml-docker | ||
| %attr(750, root, root) %config(missingok) %{_tmppath}/iml-images.tgz | ||
| %attr(750, root, root) %{_sharedstatedir}/iml-images.tgz |
There was a problem hiding this comment.
The attr be 0640
and the blow should be 0755
jgrund
commented
Jul 23, 2020
jgrund
commented
Jul 23, 2020
ip1981
approved these changes
Jul 23, 2020
johnsonw
approved these changes
Jul 23, 2020
beevans
pushed a commit
to beevans/integrated-manager-for-lustre
that referenced
this pull request
Aug 6, 2020
* Make docker image tarball a required file `iml-images.tgz` currently lives under /var/tmp and is marked as ok if it's missing. This can cause an issue if the tarball is removed, as `iml-docker` will not be able to load the images and startup. Move the tarball to `/var/lib`, and make it non-optional. Signed-off-by: Joe Grund <jgrund@whamcloud.io> * Apply suggestions from code review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iml-images.tgzcurrently lives under /var/tmpand is marked as ok if it's missing.
This can cause an issue if the tarball is removed, as
iml-dockerwillnot be able to load the images and startup.
Move the tarball to
/var/lib, and make it non-optional.Signed-off-by: Joe Grund jgrund@whamcloud.io
This change is