This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Only destroy matching sessions #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the iml-agent gets a `SESSION_DESTROY` message, it will destroy the session with a matching plugin name, even if the session id does not match. This could lead to the wrong session being destroyed. Check if the currently held session id matches the one to be destroyed. If so, destroy it, if not it's a noop. In addition, Remove the `SessionInfo` struct and replace `Seq` with `AtomicU64`. This allows us to drop a Mutex, as `AtomicU64` is lockless and threadsafe. Signed-off-by: Joe Grund <jgrund@whamcloud.io>
utopiabound
approved these changes
Jul 27, 2020
ip1981
approved these changes
Jul 28, 2020
mkpankov
approved these changes
Jul 28, 2020
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jgrund)
beevans
pushed a commit
to beevans/integrated-manager-for-lustre
that referenced
this pull request
Aug 6, 2020
If the iml-agent gets a `SESSION_DESTROY` message, it will destroy the session with a matching plugin name, even if the session id does not match. This could lead to the wrong session being destroyed. Check if the currently held session id matches the one to be destroyed. If so, destroy it, if not it's a noop. In addition, Remove the `SessionInfo` struct and replace `Seq` with `AtomicU64`. This allows us to drop a Mutex, as `AtomicU64` is lockless and threadsafe. Signed-off-by: Joe Grund <jgrund@whamcloud.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the iml-agent gets a
SESSION_DESTROYmessage, it will destroy thesession with a matching plugin name, even if the session id does not
match.
This could lead to the wrong session being destroyed.
Check if the currently held session id matches the one to be destroyed.
If so, destroy it, if not it's a noop.
In addition, Remove the
SessionInfostruct and replaceSeqwithAtomicU64. This allows us to drop a Mutex, asAtomicU64is locklessand threadsafe.
Signed-off-by: Joe Grund jgrund@whamcloud.io
This change is