This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Implement the fix #2134
Merged
Implement the fix #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlinker
commented
Aug 6, 2020
| @@ -422,7 +425,7 @@ fn job_item_combine(parent: Node<Msg>, acc: Vec<Node<Msg>>, _ctx: &mut Context) | |||
| fn job_item_cancel_button(job: &Arc<RichJob>, cancelling: bool) -> Node<Msg> { | |||
| if let Some(trans) = find_cancel_transition(job) { | |||
| let cancel_btn: Node<Msg> = div![ | |||
| class![C.inline, C.px_1, C.rounded_lg, C.text_white, C.cursor_pointer], | |||
| class![C.inline, C.ml_1, C.px_1, C.rounded_lg, C.text_white, C.cursor_pointer], | |||
There was a problem hiding this comment.
The indent for the "Cancel" button.
nlinker
commented
Aug 6, 2020
| @@ -150,6 +150,9 @@ pub fn update(msg: Msg, model: &mut Model, orders: &mut impl Orders<Msg, GMsg>) | |||
|
|
|||
| match cmds { | |||
| Input::Commands(cmds) => { | |||
| if let Some(cmd) = cmds.first() { | |||
| model.select.perform_click(TypedId::Cmd(cmd.id)); | |||
| } | |||
There was a problem hiding this comment.
select will have the first command id, and then FetchTree will do the rest
ip1981
previously approved these changes
Aug 6, 2020
nlinker
force-pushed
the
1897-open-first-command
branch
from
425b967
to
cfcd5b4
Compare
|
Looks like firefox tests are failing. Has this been rebased on master recently? |
Signed-off-by: Nick Linker <nlinker@gmail.com>
Signed-off-by: Nick Linker <nlinker@gmail.com>
nlinker
force-pushed
the
1897-open-first-command
branch
from
cfcd5b4
to
808f5c6
Compare
Let's try this. |
jgrund
approved these changes
Oct 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1897
Also added a small space before the "Cancel" button.
Signed-off-by: Nick Linker nlinker@gmail.com
This change is