This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
PR-2211 Add llapi_path2fid support #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utopiabound
suggested changes
Sep 3, 2020
| let mut fid = Fid{ seq: 0, oid: 0, ver: 0,}; | ||
|
|
||
| let rc = unsafe { | ||
| let rc = match self.lib.get(b"llapi_path2fid\0") { |
There was a problem hiding this comment.
This would be better as:
if let Ok(f) = self.lib.get(b"llapi_path2fid\0") {
...Since we don't care about what the error is.
There was a problem hiding this comment.
I think we should add a SymbolNotFound variant to LiblustreError so it's clear to the caller what went wrong.
There was a problem hiding this comment.
I'm just following the pattern of fid2path
There was a problem hiding this comment.
yeah, looks like that should be updated as well.
There was a problem hiding this comment.
So open a ticket to add SymbolNotFound to LiblustreError and handle all the cases in here?
There was a problem hiding this comment.
New ticket and fix in here is fine.
|
Looks like this code needs |
utopiabound
previously approved these changes
Sep 8, 2020
|
This needs rebase on latest master due to: #2223 |
Signed-off-by: Ben Evans <beevans@whamcloud.com>
Signed-off-by: Ben Evans <beevans@whamcloud.com>
jgrund
approved these changes
Sep 8, 2020
utopiabound
approved these changes
Sep 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Evans beevans@whamcloud.com
This change is