Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Rename "targets" table to "target" #2216

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Rename "targets" table to "target" #2216

merged 2 commits into from
Sep 8, 2020

Conversation

johnsonw
Copy link
Contributor

@johnsonw johnsonw commented Sep 3, 2020

Fixes #2198.

The table should be singular like the others for consistency.

Signed-off-by: johnsonw wjohnson@whamcloud.com


This change is Reviewable

@johnsonw johnsonw added the bug label Sep 3, 2020
@johnsonw johnsonw requested a review from a team September 3, 2020 21:20
@johnsonw johnsonw self-assigned this Sep 3, 2020
@jgrund
Copy link
Member

jgrund commented Sep 4, 2020

Needs cargo sqlx prepare -- --tests run

ip1981
ip1981 previously approved these changes Sep 4, 2020
@jgrund jgrund requested a review from a team September 4, 2020 14:23
@mkpankov
Copy link
Contributor

mkpankov commented Sep 7, 2020

Looks like there's a conflict with master

@johnsonw
Copy link
Contributor Author

johnsonw commented Sep 8, 2020

Looks like some other patches landed first. I'll have to rebase again.

Fixes #2198.

The table should be singular like the others for consistency.

Signed-off-by: johnsonw <wjohnson@whamcloud.com>
Signed-off-by: johnsonw <wjohnson@whamcloud.com>
@jgrund jgrund self-requested a review September 8, 2020 17:19
@jgrund jgrund merged commit 5a67406 into master Sep 8, 2020
@jgrund jgrund deleted the GH-2198 branch September 8, 2020 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "targets" table to "target"
4 participants