This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
EX-1687 graphql commands #2240
Merged
EX-1687 graphql commands #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We usually need a command with specific id, no? |
|
ip1981
reviewed
Sep 14, 2020
mkpankov
previously approved these changes
Sep 15, 2020
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ip1981)
Signed-off-by: Nick Linker <nlinker@gmail.com>
Signed-off-by: Nick Linker <nlinker@gmail.com>
Signed-off-by: Nick Linker <nlinker@gmail.com>
Signed-off-by: Nick Linker <nlinker@gmail.com>
Signed-off-by: Nick Linker <nlinker@gmail.com>
nlinker
force-pushed
the
ex-1687-graphql-commands
branch
from
a1ff2cb
to
66459fb
Compare
mkpankov
previously approved these changes
Sep 15, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ip1981)
ip1981
previously approved these changes
Sep 15, 2020
|
Looks like sqlx schema check is failing, otherwise LGTM. |
Signed-off-by: Nick Linker <nlinker@gmail.com>
ip1981
approved these changes
Sep 15, 2020
jgrund
approved these changes
Sep 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements GraphQL for commands.
Also fixes some clippy warnings.
This change is