This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
GH-2268 Update the limit param in graphql api's #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ip1981
reviewed
Sep 23, 2020
jgrund
suggested changes
Sep 24, 2020
ip1981
reviewed
Sep 24, 2020
| limit.unwrap_or(20) as i64 | ||
| limit | ||
| .map(|x| x.to_string()) | ||
| .unwrap_or_else(|| "ALL".to_string()) as String |
There was a problem hiding this comment.
It required the cast.
Fixes #2268.
Currently, the limit param allows you to specify a limit when retrieving items back from an API call. This is a numeric value that can be passed in but in some cases, we may want all results. To address this, postress allows us to pass in ALL instead of a numeric value, which is effectively the same as not passing a limit at all. Update all of the graphql API endpoints such that if None is passed in it will pass ALL to the LIMIT clause in the query. This will allow us to get all entries without modifying the existing api.
Signed-off-by: johnsonw <wjohnson@whamcloud.com>
Signed-off-by: johnsonw <wjohnson@whamcloud.com>
Signed-off-by: johnsonw <wjohnson@whamcloud.com>
Signed-off-by: johnsonw <wjohnson@whamcloud.com>
jgrund
reviewed
Sep 24, 2020
iml-api/src/graphql.rs
Outdated
| @@ -136,7 +136,7 @@ pub(crate) struct QueryRoot; | |||
| #[juniper::graphql_object(Context = Context)] | |||
| impl QueryRoot { | |||
| #[graphql(arguments( | |||
| limit(description = "paging limit, defaults to 20"), | |||
| limit(description = "paging limit, defaults to All"), | |||
There was a problem hiding this comment.
Maybe:
Suggested change
| limit(description = "paging limit, defaults to All"), | |
| limit(description = "optional paging limit, defaults to all rows"), |
Signed-off-by: johnsonw <wjohnson@whamcloud.com>
jgrund
approved these changes
Sep 24, 2020
ip1981
approved these changes
Sep 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2268.
Currently, the limit param allows you to specify a limit when retrieving items back from an API call. This is a numeric value that can be passed in but in some cases, we may want all results. To address this, postress allows us to pass in ALL instead of a numeric value, which is effectively the same as not passing a limit at all. Update all of the graphql API endpoints such that if None is passed in it will pass ALL to the LIMIT clause in the query. This will allow us to get all entries without modifying the existing api.
Signed-off-by: johnsonw wjohnson@whamcloud.com
This change is