This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Remove CLI indirection #2294
Merged
Remove CLI indirection #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docker iml cli had an extra layer of indirection where it would source a profile before invoking the iml binary. This may have been done prior to using .dotenv in the cli binary, but it's no longer needed so we can remove all of it. Signed-off-by: Joe Grund <jgrund@whamcloud.io>
Merged
utopiabound
approved these changes
Oct 1, 2020
johnsonw
approved these changes
Oct 1, 2020
beevans
approved these changes
Oct 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker iml cli had an extra layer of indirection where it would
source a profile before invoking the iml binary.
This may have been done prior to using .dotenv in the cli binary, but
it's no longer needed so we can remove all of it.
Signed-off-by: Joe Grund jgrund@whamcloud.io
This change is