This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
EX-1874 stratagem: iml-agent needs to be more verbose #2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report success and failures from iml-agent filesync and cloudsync jobs Signed-off-by: Ben Evans <beevans@whamcloud.com>
jgrund
reviewed
Oct 6, 2020
iml-agent/src/cli.rs
Outdated
| @@ -560,7 +560,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> { | |||
| let fids: Vec<_> = fids.into_iter().map(Result::unwrap).collect(); | |||
| let errors: Vec<_> = errors.into_iter().map(Result::unwrap_err).collect(); | |||
| if !errors.is_empty() { | |||
| tracing::error!("files not found, ignoring: {:?}", errors); | |||
| println!("files not found, ignoring: {:?}", errors); | |||
There was a problem hiding this comment.
nit:
Suggested change
| println!("files not found, ignoring: {:?}", errors); | |
| eprintln!("files not found, ignoring: {:?}", errors); |
jgrund
reviewed
Oct 6, 2020
| exit(0); | ||
| } | ||
|
|
||
| for err in reslist.iter() { |
There was a problem hiding this comment.
As many items as the user typed in (not more)
jgrund
reviewed
Oct 6, 2020
iml-agent/src/cli.rs
Outdated
| match result { | ||
| Ok(reslist) => { | ||
| if reslist.is_empty() { | ||
| println!("Ok!"); |
There was a problem hiding this comment.
Suggested change
| println!("Ok!"); | |
| println!("FIDs processed successfully"); |
jgrund
reviewed
Oct 6, 2020
iml-agent/src/cli.rs
Outdated
| } | ||
|
|
||
| for err in reslist.iter() { | ||
| println!( |
There was a problem hiding this comment.
Suggested change
| println!( | |
| eprintln!( |
jgrund
reviewed
Oct 6, 2020
iml-agent/src/cli.rs
Outdated
| } | ||
| } | ||
| Err(e) => { | ||
| println!("cloudsync failed {}", e); |
There was a problem hiding this comment.
Suggested change
| println!("cloudsync failed {}", e); | |
| eprintln!("cloudsync failed {}", e); |
Signed-off-by: Ben Evans <beevans@whamcloud.com>
jgrund
approved these changes
Oct 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report success and failures from iml-agent filesync and
cloudsync jobs
Signed-off-by: Ben Evans beevans@whamcloud.com
This change is