This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
EX-1932 handle softlinks for llapi queries #2325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When constructing an llapi instance from a random path liblustreapi first resolves that path fully, including symbolic links. This causes a failure when trying to get an llapi instance from a symbolic link that lives on a lustre filesystem (ex /mnt/lustre/symbolic_link) If the path passed into search_fsname is a link, use the parent dir instead. Signed-off-by: Ben Evans <beevans@whamcloud.com>
jgrund
reviewed
Oct 12, 2020
Signed-off-by: Ben Evans <beevans@whamcloud.com>
Signed-off-by: Ben Evans <beevans@whamcloud.com>
jgrund
reviewed
Oct 13, 2020
Signed-off-by: Ben Evans <beevans@whamcloud.com>
jgrund
approved these changes
Oct 13, 2020
jgrund
pushed a commit
that referenced
this pull request
Oct 14, 2020
* EX-1932 handle softlinks for llapi queries When constructing an llapi instance from a random path liblustreapi first resolves that path fully, including symbolic links. This causes a failure when trying to get an llapi instance from a symbolic link that lives on a lustre filesystem (ex /mnt/lustre/symbolic_link) If the path passed into search_fsname is a link, use the parent dir instead. Signed-off-by: Ben Evans <beevans@whamcloud.com> * Code review fixes Signed-off-by: Ben Evans <beevans@whamcloud.com> * Indent code correctly Signed-off-by: Ben Evans <beevans@whamcloud.com> * More review comments Signed-off-by: Ben Evans <beevans@whamcloud.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When constructing an llapi instance from a random path
liblustreapi first resolves that path fully, including
symbolic links. This causes a failure when trying to
get an llapi instance from a symbolic link that lives on
a lustre filesystem (ex /mnt/lustre/symbolic_link)
If the path passed into search_fsname is a link, use
the parent dir instead.
Signed-off-by: Ben Evans beevans@whamcloud.com
This change is