This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Update action-client #2356
Merged
Update action-client #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update action-client once again to optionally take a uuid that can be used to bookkeep the request in flight. In addition, remove `invoke_rust_agent_cancelable` as it adds an extra layer of indirection that is more useful in tools calling the client. Replace it with a `cancel_request` fn that will take a `Uuid` ref and attempt to cancel a remote rpc matching the uuid. Signed-off-by: Joe Grund <jgrund@whamcloud.io>
ip1981
approved these changes
Oct 30, 2020
johnsonw
reviewed
Oct 30, 2020
Yeah, but not from this patch. I actually think there is a clippy issue inside that macro:
|
johnsonw
approved these changes
Oct 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update action-client once again to optionally take a uuid that can be
used to bookkeep the request in flight.
In addition, remove
invoke_rust_agent_cancelableas it adds an extralayer of indirection that is more useful in tools calling the client.
Replace it with a
cancel_requestfn that will take aUuidref andattempt to cancel a remote rpc matching the uuid.
Signed-off-by: Joe Grund jgrund@whamcloud.io
This change is