This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
Add rust rpm provisioner to adm node #2382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgrund
reviewed
Nov 13, 2020
jgrund
reviewed
Nov 14, 2020
ip1981
previously approved these changes
Nov 18, 2020
mkpankov
previously approved these changes
Nov 18, 2020
jgrund
reviewed
Nov 18, 2020
johnsonw
force-pushed
the
add-rust-rpm-provisioner
branch
from
d41b49d
to
6ad5033
Compare
jgrund
reviewed
Nov 30, 2020
Building the rpms locally has been difficult becuase using the docker container is significantly slower, even after increasing the available ram and cpu's. In contrast, building in the adm vm appears to be nearly as fast as building on the host. Furthermore, adding sccache appears to maintain dependency builds across different branches, allowing for much quicker builds. This patch adds a new provisioner to build the rust rpms using the adm virtual machine and takes care of installing all necessary dependencies, including sccache. To build the rust rpms, simply run the following: ``` vagrant provision adm --provision-with build-rust-rpms ``` Signed-off-by: johnsonw <wjohnson@whamcloud.com>
Signed-off-by: johnsonw <wjohnson@whamcloud.com>
Signed-off-by: johnsonw <wjohnson@whamcloud.com>
Signed-off-by: johnsonw <wjohnson@whamcloud.com>
…e adm node and resource it before running make. Signed-off-by: johnsonw <wjohnson@whamcloud.com>
…nt variable to the Make environment Signed-off-by: johnsonw <wjohnson@whamcloud.com>
johnsonw
force-pushed
the
add-rust-rpm-provisioner
branch
from
6ad5033
to
22e476d
Compare
|
Output from latest run: |
|
Test passing here: https://build.whamcloud.com/job/manager-for-lustre/3148/ |
jgrund
approved these changes
Dec 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the rpms locally has been difficult becuase using the docker
container is significantly slower, even after increasing the available
ram and cpu's. In contrast, building in the adm vm appears to be nearly
as fast as building on the host. Furthermore, adding sccache appears to
maintain dependency builds across different branches, allowing for much
quicker builds. This patch adds a new provisioner to build the rust rpms
using the adm virtual machine and takes care of installing all necessary
dependencies, including sccache. To build the rust rpms, simply run the
following:
Signed-off-by: johnsonw wjohnson@whamcloud.com
This change is