Support symbol of value 0 (#98)

* bug fix: support symbol(0) * added more exceptions
wharfkit · Jan 20, 2024 · f09366a · f09366a
1 parent 6945643
commit f09366a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/chain/asset.ts b/src/chain/asset.ts
@@ -126,9 +126,12 @@ export namespace Asset {
                 return new Symbol(value)
             }
             const parts = value.split(',')
-            if (parts.length !== 2) {
+            if (parts.length !== 2 && value !== '0,') {
                 throw new Error('Invalid symbol string')
             }
+            if (value === '0,') {
+                parts.push("")
+            }
             const precision = Number.parseInt(parts[0])
             return Symbol.fromParts(parts[1], precision)
         }
@@ -152,7 +155,7 @@ export namespace Asset {
             if (toSymbolPrecision(value) > Symbol.maxPrecision) {
                 throw new Error('Invalid asset symbol, precision too large')
             }
-            if (!SymbolCode.pattern.test(toSymbolName(value))) {
+            if (value !== UInt64.from(0) && !SymbolCode.pattern.test(toSymbolName(value))) {
                 throw new Error('Invalid asset symbol, name must be uppercase A-Z')
             }
             this.value = value
@@ -229,7 +232,7 @@ export namespace Asset {
         value: UInt64
 
         constructor(value: UInt64) {
-            if (!SymbolCode.pattern.test(toSymbolName(value))) {
+            if (value !== UInt64.from(0) && !SymbolCode.pattern.test(toSymbolName(value))) {
                 throw new Error('Invalid asset symbol, name must be uppercase A-Z')
             }
             this.value = value

diff --git a/test/chain.ts b/test/chain.ts
@@ -55,6 +55,12 @@ suite('chain', function () {
         assert.equal(symbol.precision, '10')
         assert.equal(Asset.Symbol.from(symbol.value).toString(), symbol.toString())
 
+        const nft_symbol = Asset.Symbol.from(Asset.Symbol.from('0,'))
+        assert.equal(nft_symbol.name, '')
+        assert.equal(nft_symbol.precision, '0')
+        assert.equal(Asset.Symbol.from(nft_symbol.value).toString(), nft_symbol.toString())
+        assert.equal(nft_symbol.value, 0)
+
         // test null asset
         asset = Asset.from('0 ')
         assert.equal(Number(asset.value), 0)