Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "NotSupportedError" when trying to attachShadow() twice #761

Merged
merged 1 commit into from
May 16, 2019

Conversation

domenic
Copy link
Member

@domenic domenic commented May 15, 2019

Discussed in #760. This makes the various cases less distinguishable,
which is desirable. With this change, all three cases behave the same
between:

  • A custom element with disabled-shadow
  • A custom element with a shadow tree
  • A built-in element on the blocklist

Tests: web-platform-tests/wpt#16853


Preview | Diff

Discussed in #760. This makes the various cases less distinguishable,
which is desirable. With this change, all three cases behave the same
between:

- A custom element with disabled-shadow
- A custom element with a shadow tree
- A built-in element on the blocklist
Copy link
Collaborator

@tkent-google tkent-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
Maybe we need another implementer interest?

@annevk
Copy link
Member

annevk commented May 16, 2019

I think I can say that Mozilla is fine with this change.

@domenic domenic merged commit bcdab96 into master May 16, 2019
@domenic domenic deleted the notsupportederror-everywhere branch May 16, 2019 15:11
domenic added a commit to web-platform-tests/wpt that referenced this pull request May 16, 2019
@domenic
Copy link
Member Author

domenic commented May 16, 2019

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jun 19, 2019
…), a=testonly

Automatic update from web-platform-tests
Update error type test for attachShadow()

Follows whatwg/dom#761.

--

wp5At-commits: 7deb0225341a149c78db1d4515314e781985b3ff
wpt-pr: 16853
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Jun 19, 2019
…), a=testonly

Automatic update from web-platform-tests
Update error type test for attachShadow()

Follows whatwg/dom#761.

--

wp5At-commits: 7deb0225341a149c78db1d4515314e781985b3ff
wpt-pr: 16853
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 23, 2019
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
…), a=testonly

Automatic update from web-platform-tests
Update error type test for attachShadow()

Follows whatwg/dom#761.

--

wp5At-commits: 7deb0225341a149c78db1d4515314e781985b3ff
wpt-pr: 16853

UltraBlame original commit: ee83ec4d28891ea032dca765518c5a5e9dec16b3
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
…), a=testonly

Automatic update from web-platform-tests
Update error type test for attachShadow()

Follows whatwg/dom#761.

--

wp5At-commits: 7deb0225341a149c78db1d4515314e781985b3ff
wpt-pr: 16853

UltraBlame original commit: ee83ec4d28891ea032dca765518c5a5e9dec16b3
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
…), a=testonly

Automatic update from web-platform-tests
Update error type test for attachShadow()

Follows whatwg/dom#761.

--

wp5At-commits: 7deb0225341a149c78db1d4515314e781985b3ff
wpt-pr: 16853

UltraBlame original commit: ee83ec4d28891ea032dca765518c5a5e9dec16b3
zdobersek pushed a commit to Igalia/webkit that referenced this pull request Oct 5, 2019
https://bugs.webkit.org/show_bug.cgi?id=197948

Reviewed by Wenson Hsieh.

LayoutTests/imported/w3c:

Rebaselined the tests.

* web-platform-tests/shadow-dom/Element-interface-attachShadow-custom-element-expected.txt:
* web-platform-tests/shadow-dom/Element-interface-attachShadow-expected.txt:

Source/WebCore:

Match the latest spec. See whatwg/dom#761

* dom/Element.cpp:
(WebCore::Element::attachShadow): Throw NotSupportedError when there is already a shadow tree.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@250764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants