Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use HTMLDocument where applicable #799

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: Use HTMLDocument where applicable #799

wants to merge 4 commits into from

Conversation

ExE-Boss
Copy link

@ExE-Boss ExE-Boss commented Dec 4, 2019 •
edited by pr-preview bot
Loading

See issues: whatwg/html#4792, #221 and #278

Depends on whatwg/html#5104

This is already implemented in all major browsers (Firefox, Chrome and Safari).

review?(@annevk, @domenic)

💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Jan 15, 2021, 7:33 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.

🔗 Related URL

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>500 Internal Server Error</title>
</head><body>
<h1>Internal Server Error</h1>
<p>The server encountered an internal error or
misconfiguration and was unable to complete
your request.</p>
<p>Please contact the server administrator at 
 [no address given] to inform them of the time this error occurred,
 and the actions you performed just before this error.</p>
<p>More information about this error may be available
in the server error log.</p>
<hr>
<address>Apache/2.4.10 (Debian) Server at api.csswg.org Port 443</address>
</body></html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

annevk
annevk reviewed Dec 5, 2019
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me once the other bits are in order. We should probably also ensure there's test coverage for this as I don't think our IDL test generator is smart enough to automatically test this.

dom.bs Outdated Show resolved Hide resolved
dom.bs Outdated Show resolved Hide resolved
@annevk annevk added needs tests Moving the issue forward requires someone to write tests do not merge yet Pull request must not be merged per rationale in comment labels Dec 5, 2019
@ExE-Boss @annevk
fix: Improve wording of create*Document(…) method definitions
8866a83 
Co-Authored-By: Anne van Kesteren <annevk@annevk.nl>
@ExE-Boss ExE-Boss mentioned this pull request Dec 8, 2019
Open
2 tasks
@ExE-Boss ExE-Boss closed this Dec 9, 2019
@ExE-Boss ExE-Boss reopened this Dec 9, 2019
Base automatically changed from master to main January 15, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk left review comments

Assignees
No one assigned
Labels
do not merge yet Pull request must not be merged per rationale in comment needs tests Moving the issue forward requires someone to write tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ExE-Boss @annevk