Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Review Draft infrastructure #145

Merged
merged 2 commits into from
May 29, 2018
Merged

Conversation

annevk
Copy link
Member

@annevk annevk commented May 29, 2018

See whatwg/whatwg.org#197 and whatwg/meta#92 for details.

This also updates the web-platform-tests and IRC URLs.

See whatwg/whatwg.org#197 and whatwg/meta#92 for details.

This also updates the web-platform-tests and IRC URLs.
@annevk
Copy link
Member Author

annevk commented May 29, 2018

Contrasting this with Console, I guess what we should be doing here is to move the environment variables from .travis.yml to Makefile?

@domenic
Copy link
Member

domenic commented May 29, 2018

Agreed, then you can successfully deploy using the Makefile

@annevk
Copy link
Member Author

annevk commented May 29, 2018

Hmm, I cannot get

deploy: encoding.bs
	export CHECKER_FILTER="Text run is not in Unicode Normalization Form C\.|.*appears to be written in.*|.*Charmod C073.*"
	export EXTRA_FILES="*.txt *.json *.css"
	export POST_BUILD_STEP='python visualize.py "$DIR/"'
	curl --remote-name --fail https://resources.whatwg.org/build/deploy.sh && bash ./deploy.sh

to work. Also when I omit export .

It also does not work for Console for me locally. Perhaps that's just a bug in make on macOS?

@domenic
Copy link
Member

domenic commented May 29, 2018

Hmm, I'm not a Make expert, although https://stackoverflow.com/q/23843106 has a number of interesting things... I was just going to do this though (note the line-ending \s):

deploy: encoding.bs
  curl --remote-name --fail https://resources.whatwg.org/build/deploy.sh
	CHECKER_FILTER="Text run is not in Unicode Normalization Form C\.|.*appears to be written in.*|.*Charmod C073.*" \
	EXTRA_FILES="*.txt *.json *.css" \
	POST_BUILD_STEP='python visualize.py "$DIR/"' \
	bash ./deploy.sh

@annevk
Copy link
Member Author

annevk commented May 29, 2018

That works better, thanks. Now the problem is that $D is removed.

@annevk
Copy link
Member Author

annevk commented May 29, 2018

@domenic domenic merged commit b04091a into master May 29, 2018
@domenic domenic deleted the annevk/review-draft-infra branch May 29, 2018 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants