Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP-network-or-cache fetch request cloning #1176

Closed
annevk opened this issue Feb 19, 2021 · 1 comment · Fixed by #1177
Closed

HTTP-network-or-cache fetch request cloning #1176

annevk opened this issue Feb 19, 2021 · 1 comment · Fixed by #1177

Comments

@annevk
Copy link
Member

annevk commented Feb 19, 2021

Thanks to @yutakahirano I spotted some weird behavior about how we deal with request cloning in the network. It sets stream to null rather than source.

But maybe we should just use clone as we also do for service workers and mention that implementers can avoid teeing due to the source null checks.
@annevk
Copy link
Member Author

annevk commented Feb 19, 2021

@yutakahirano I blamed this and it seems we did settle on this text somehow, but I guess we were both confused? 0cef38e 😊

I'll create a PR.

annevk added a commit that referenced this issue Feb 19, 2021
@annevk
Give all bodies a stream
2fa49c0 
This simplifies some wording introduced in #425 and aligns it with the recently introduced cloning for service workers.

Fixes #1176.
@annevk annevk mentioned this issue Feb 19, 2021
Merged
annevk added a commit that referenced this issue Feb 24, 2021
@annevk
Give all bodies a stream
0f29092 
This simplifies some wording introduced in #425 and aligns it with the recently introduced cloning for service workers.

Fixes #1176.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Give all bodies a stream whatwg/fetch
1 participant
@annevk