Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point default referrer policy to a constant defined in RP spec #1066

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Point default referrer policy to a constant defined in RP spec #1066

merged 1 commit into from
Nov 30, 2020

Conversation

krgovind
Copy link
Contributor

@krgovind krgovind commented Aug 3, 2020 •
edited by pr-preview bot
Loading

This is a re-do of #952 started by @mikewest since I am taking over the relevant spec updates.

This spec will now point to a constant defined in w3c/webappsec-referrer-policy/pull/142 as the default referrer policy.

Preview | Diff

@annevk
Copy link
Member

annevk commented Aug 4, 2020

Thank you! You'll need to make your membership of the googlers organization public.

@annevk annevk mentioned this pull request Aug 4, 2020
Closed
@krgovind
Copy link
Contributor Author

krgovind commented Aug 4, 2020

Thank you! You'll need to make your membership of the googlers organization public.

Done! It's my first time contributing to specs, so still discovering all the boxes I need to check off. :)

@annevk
Copy link
Member

annevk commented Aug 5, 2020 •
edited
Loading

Great! (Landing this is blocked on w3c/webappsec-referrer-policy#142.)

@annevk annevk added the do not merge yet Pull request must not be merged per rationale in comment label Aug 6, 2020
domfarolino
domfarolino approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And as Anne said, I think we'll hold off on merging this until:

  • Referrer Policy spec changes lands
  • WPTs are ready to land

@domfarolino domfarolino mentioned this pull request Sep 24, 2020
Merged
@krgovind
Copy link
Contributor Author

Great! (Landing this is blocked on w3c/webappsec-referrer-policy#142.)

w3c/webappsec-referrer-policy#142 has now landed. Could we merge this please?

@CYBAI CYBAI mentioned this pull request Nov 28, 2020
Closed
@annevk
Copy link
Member

annevk commented Nov 30, 2020

From the Referrer Policy issue:

Is there a Safari bug? At least I got the impression they did not ship a strict superset of this.

@annevk annevk removed the do not merge yet Pull request must not be merged per rationale in comment label Nov 30, 2020
@annevk annevk merged commit eda4152 into whatwg:master Nov 30, 2020
@krgovind
Copy link
Contributor Author

Safari bug is here.

@annevk
Copy link
Member

annevk commented Nov 30, 2020

Thanks @krgovind! Glad this is mostly wrapped up now. I rebased the HTML PR and hopefully @domenic will have time for that soonish.

@hamishwillee hamishwillee mentioned this pull request Mar 1, 2021
Merged
@github-actions github-actions bot mentioned this pull request Apr 27, 2021
Merged
@github-actions github-actions bot mentioned this pull request May 26, 2021
Merged
This was referenced Aug 5, 2021
Merged
Merged
@github-actions github-actions bot mentioned this pull request Nov 19, 2021
Merged
@github-actions github-actions bot mentioned this pull request Jul 22, 2022
Merged
@github-actions github-actions bot mentioned this pull request Sep 4, 2022
Merged
@github-actions github-actions bot mentioned this pull request Oct 1, 2022
Merged
@shurintou shurintou mentioned this pull request Feb 19, 2023
Open
@github-actions github-actions bot mentioned this pull request Mar 3, 2023
Merged
This was referenced Jul 11, 2024
Merged
Merged
This was referenced Jul 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domfarolino domfarolino domfarolino approved these changes

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krgovind @annevk @domfarolino