Expose a mechanism for hiding internal timing info #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for whatwg/html#7104 and later on for whatwg#1215. Navigation timing reports the timing info from the HTML spec, so it needs a mechanism to obfuscate the internals. So far that obfuscation was internal to fetch and was done upon reporting.
annevk
reviewed
Sep 28, 2021
There was a problem hiding this comment.
Looks good modulo nits. If we end up creating fetch timing info instances in more places, we should perhaps consider an abstraction for that too. In the two places where we do that today in Fetch we always set start time and post-redirect start time to the same value and adjust nothing else.
fetch.bs
Outdated
| opaque timing info</dfn>, given a <a for=/>fetch timing info</a> <var>timingInfo</var>, | ||
| create a new <a for=/>fetch timing info</a> whose <a for="fetch timing info">start time</a> and | ||
| <a for="fetch timing info">post-redirect start time</a> are <var>timingInfo</var>'s | ||
| <a for="fetch timing info">start time</a>. |
There was a problem hiding this comment.
Indentation is wrong in this block. Also has newlines inside phrasing elements.
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for whatwg/html#7104
and later on for #1215.
Navigation timing reports the timing info from the HTML spec,
so it needs a mechanism to obfuscate the internals. So far that
obfuscation was internal to fetch and was done upon reporting.
Preview | Diff