Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit destination for <iframe>, <frame>, <embed>, and <object>. #948

Merged
merged 2 commits into from
Jun 5, 2020
Merged

Revisit destination for <iframe>, <frame>, <embed>, and <object>. #948

merged 2 commits into from
Jun 5, 2020

Commits on Jun 4, 2020

  1. Revisit navigation requests' destination. 

    As discussed in w3c/webappsec-fetch-metadata#45, this patch splits the
`document` destination into `document`, `frame`, and `iframe`. These
destinations distinguish top-level navigation from nested navigation,
and exposing this data via `Sec-Fetch-Dest` will allow developers to
better understand the nature of a request.

This patch also redefines "navigation request" and "non-subresource
request" to include `embed` and `object` destinations as a consequence
of the conversation in [1], which will also change the `mode` of those
requests from `no-cors` to `navigate` [2].

These changes are covered by WPT in //fetch/metadata, specifically
[3], [4], [5], and [6].

[1]: #948 (comment)
[2]: https://github.com/whatwg/html/pull/4976/files
[3]: https://github.com/web-platform-tests/wpt/blob/master/fetch/metadata/embed.tentative.https.sub.html
[4]: https://github.com/web-platform-tests/wpt/blob/master/fetch/metadata/object.tentative.https.sub.html
[5]: https://github.com/web-platform-tests/wpt/blob/master/fetch/metadata/iframe.tentative.https.sub.html
[6]: https://github.com/web-platform-tests/wpt/blob/master/fetch/metadata/navigation.tentative.https.sub.html
    @mikewest @annevk
    mikewest authored and annevk committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    8455c31 View commit details
    Browse the repository at this point in the history

  2. nit

    @annevk
    annevk committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    939613d View commit details
    Browse the repository at this point in the history