Skip to content

Conversation

@a-sully
Copy link
Collaborator

@a-sully a-sully commented Jun 20, 2023

Before: {{WriteCommandType/"write"}}
After: "{{WriteCommandType/write}}"

Fixes #133


Preview | Diff

Before: `{{WriteCommandType/"write"}}`
After: `"{{WriteCommandType/write}}"`

Fixes whatwg#133
@a-sully a-sully requested a review from annevk June 20, 2023 21:42
@a-sully
Copy link
Collaborator Author

a-sully commented Jun 20, 2023

Question: should strings like "readwrite" be converted to "{{FileSystemPermissionMode/readwrite}}"? Presumably that would require moving the declaration of FileSystemPermissionMode to this spec, though. Not sure if that's something we want to do

@inexorabletash
Copy link
Member

I defer to Anne of course, but if they're internal state not enum members, then I'd keep them as strings. I'd use https://fetch.spec.whatwg.org/#fetch-controller-state as an analogue.

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I agree with @inexorabletash. We do want to format strings the same way as enums, but I think we're doing that already.

@annevk annevk merged commit 0bade6e into whatwg:main Jun 21, 2023
@a-sully a-sully deleted the fix-133 branch June 21, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Editorial: string formatting

3 participants