-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS colors parsed for canvas use should explicitly state the element to resolve currentcolor against #10398
Labels
Comments
Ah, I messed this up in #10175. I will take this. |
The current text reads:
The We shouldn't pass anything though when that is not a For reference: https://drafts.csswg.org/css-color-4/#parse-a-css-color-value |
annevk
added a commit
that referenced
this issue
Jun 6, 2024
Also modernize the way we handle shadowColor. Closes #10398.
annevk
added a commit
that referenced
this issue
Jun 8, 2024
Also modernize the way we handle shadowColor. Closes #10398.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the issue with the HTML Standard?
Various sections that define how 2D canvas context APIs parse CSS color values link to the "parse a CSS
<color>
value" algorithm in the CSS Color spec. That algorithm expects to be passed in the specific element to resolve currentcolor against, and if no element is passed in, currentcolor resolves to the initial value of 'color'.The uses of "parse a CSS '' value" (e.g. in the fillStyle setter) do not pass in an element, but there are WPTs that assume it resolves against the
<canvas>
element (e.g. html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.current.basic).The text was updated successfully, but these errors were encountered: