Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two issues with the steps determine "starting value" of <ol reversed> #1911

Closed
upsuper opened this issue Oct 16, 2016 · 1 comment · Fixed by #2002
Closed

Two issues with the steps determine "starting value" of <ol reversed> #1911

upsuper opened this issue Oct 16, 2016 · 1 comment · Fixed by #2002

Comments

@upsuper
Copy link
Member

upsuper commented Oct 16, 2016

  1. It should count not only <li> children, but also descendent <li>s which are not wrapped in other <ol> or <ul>.
  2. It should not count <li>s which are not rendered.

I think the above behavior matches what browsers do currently.

(I thought it had been raised in either #1750 or #1617, but it seems to me none of them mentions the steps for "starting value" of <ol>.)
domenic added a commit that referenced this issue Oct 17, 2016
@domenic
Fix the definition of the ol.start IDL attribute
76fbae8 
Closes #1750, by settling on the Firefox/Edge behavior. There is a
separate issue of defining the "starting value" concept correctly; that
is #1911.
This was referenced Oct 17, 2016
Merged
Closed
@domenic
Copy link
Member

domenic commented Oct 17, 2016

You're right that this is a separate issue from #1617. Although, it is closely related, and so we should probably solve them both at the same time.

I wonder if the "not being rendered" consideration applies to #1617 too. Per http://jsbin.com/jekokitonu/edit?html,css,js,output, it looks like it does, eek.

domenic added a commit that referenced this issue Oct 20, 2016
@domenic
Fix the definition of the ol.start IDL attribute
930b7f1 
Closes #1750, by settling on the Firefox/Edge behavior. There is a
separate issue of defining the "starting value" concept correctly; that
is #1911.
domenic added a commit that referenced this issue Nov 1, 2016
@domenic
Fix how <li>s are numbered and associated with <ol>s
8e01247 
Closes #1911 and closes #1617.
@domenic domenic mentioned this issue Nov 1, 2016
Merged
domenic added a commit that referenced this issue Nov 8, 2016
@domenic
Fix how <li>s are numbered and associated with <ol>s
fd726b0 
Closes #1911 and closes #1617.
alice pushed a commit to alice/html that referenced this issue Jan 8, 2019
@domenic
Fix the definition of the ol.start IDL attribute
c7fe93b 
Closes whatwg#1750, by settling on the Firefox/Edge behavior. There is a
separate issue of defining the "starting value" concept correctly; that
is whatwg#1911.
alice pushed a commit to alice/html that referenced this issue Jan 8, 2019
@domenic
Fix how <li>s are numbered and associated with <ol>s
84a7260 
Closes whatwg#1911 and closes whatwg#1617.
@fantasai fantasai mentioned this issue Aug 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix how <li>s are numbered and associated with <ol>s whatwg/html
2 participants
@upsuper @domenic