Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocked popup should not throw an exception #2141

Open
zcorpan opened this issue Dec 7, 2016 · 2 comments
Open

Blocked popup should not throw an exception #2141

zcorpan opened this issue Dec 7, 2016 · 2 comments
Labels
needs tests Moving the issue forward requires someone to write tests normative change

Comments

@zcorpan
Copy link
Member

zcorpan commented Dec 7, 2016

See #2140 (comment)

Test https://jsbin.com/jawuqeq/1/edit?html,console,output

Should also test what happens in the sandbox case.
@zcorpan zcorpan mentioned this issue Dec 7, 2016
Merged
@domenic
Copy link
Member

domenic commented Dec 7, 2016

It's impossible to write web platform tests for this because the pop-up blocker is always disabled there, right?

@zcorpan
Copy link
Member Author

zcorpan commented Dec 7, 2016

Right... 😑 Ironically it would have to be a manual test right now. web-platform-tests/wpt#3867

@domenic domenic mentioned this issue Jul 13, 2017
Open
31 tasks
@zcorpan zcorpan added normative change needs tests Moving the issue forward requires someone to write tests labels Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs tests Moving the issue forward requires someone to write tests normative change
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zcorpan @domenic