Revert part of "Allow <a>/<area> with download="" to not require user activation" #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… activation" This reverts part of commit 5de03c7. The second condition should be kept, it is for the popup blocker and preventing links in a sandbox to break out of the sandbox. See https://github.com/whatwg/html/pull/2136/files#r91211559
|
Thanks. However according to my testing nobody actually throws the InvalidAccessError: https://jsbin.com/jawuqeq/1/edit?html,console,output (haven't tested Safari) (Gonna sleep now, but feel free to merge in order to get things un-broken and leave the InvalidAccessError question for a follow-up...) |
|
"no exception thrown" in Safari Technology Preview. Followup issue about the exception: #2141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts part of commit 5de03c7.
The second condition should be kept, it is for the popup blocker and
preventing links in a sandbox to break out of the sandbox.
See https://github.com/whatwg/html/pull/2136/files#r91211559