Allow <a>/<area> with download="" to not require user activation #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
added
the
needs tests
31 tasks
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 5, 2016
That is, that calling .click() does not throw at least, as it used to per-spec. Matches the HTML change at whatwg/html#2136 per the HTML bug report at whatwg/html#2116.
domenic
removed
the
needs tests
|
LGTM |
annevk
reviewed
Dec 7, 2016
| data-x="attr-hyperlink-target">target</code> attribute is present, and applying <span>the rules | ||
| for choosing a browsing context given a browsing context name</span>, using the value of the | ||
| <code data-x="attr-hyperlink-target">target</code> attribute as the browsing context name, would | ||
| result in there not being a chosen browsing context, then run these substeps:</p> |
There was a problem hiding this comment.
This restriction was not just about the download attribute. And the commit message doesn't acknowledge the other bit? Did you mistakenly remove too much here?
There was a problem hiding this comment.
Oops, sloppy reviewing on my part. I guess I glossed over "or" and read it as "and". sandbox...
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 8, 2017
That is, that calling .click() does not throw at least, as it used to per-spec. Matches the HTML change at whatwg/html#2136 per the HTML bug report at whatwg/html#2116.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2116, wherein it is documented that this restriction is not
supported in any existing engines and attempting to do so in WebKit
proved not web-compatible.
Also helps with #1431.
Tests: web-platform-tests/wpt#4283