Add tests that <a>/<area> can be downloaded without user interaction #4283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is, that calling .click() does not throw at least, as it used to per-spec. Matches the HTML change at whatwg/html#2136 per the HTML bug report at whatwg/html#2116.
|
Notifying @Ms2ger, @ayg, @gsnedders, @jdm, @jgraham, @sideshowbarker, @zcorpan, and @zqzhang. (Learn how reviewing works.) |
FirefoxTesting revision 2c62408 All results/html/semantics/embedded-content/the-area-element/area-download-click.html
/html/semantics/text-level-semantics/the-a-element/a-download-click.html
|
ChromeTesting revision 2c62408 All results/html/semantics/embedded-content/the-area-element/area-download-click.html
/html/semantics/text-level-semantics/the-a-element/a-download-click.html
|
|
LGTM. @jgraham this pops up a download dialog in Firefox. Is that a problem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is, that calling .click() does not throw at least, as it used to
per-spec. Matches the HTML change at
whatwg/html#2136 per the HTML bug report at
whatwg/html#2116.
/cc @cdumez