Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make focus events composed #3511

Closed
annevk opened this issue Feb 27, 2018 · 6 comments
Closed

Make focus events composed #3511

annevk opened this issue Feb 27, 2018 · 6 comments
Labels
topic: shadow Relates to shadow trees (as defined in DOM)

Comments

@annevk
Copy link
Member

annevk commented Feb 27, 2018

Since focus events are UI events, they should be composed. https://html.spec.whatwg.org/multipage/interaction.html#fire-a-focus-event needs to be updated and I guess we should add some tests.

(Note that #1583 captures other issues around focus.)

cc @whatwg/components

@annevk annevk added the topic: shadow Relates to shadow trees (as defined in DOM) label Feb 27, 2018
annevk added a commit that referenced this issue Feb 27, 2018
@TakayoshiKochi
Copy link
Member

This sounds reasonable to me.

@hayatoito
Copy link
Member

This sounds reasonable, however, I think there are several checkpoints before changing the behavior:

@TakayoshiKochi

  • Could you do double-check that this change doesn't have any impact on https://w3c.github.io/webcomponents/spec/shadow/#focus ?
  • Also it could be a breaking change. Could you confirm that Blink wouldn't break existing Web sites? I think it is unlikely, but that could be.

ping also @rniwa.

@annevk
Copy link
Member Author

annevk commented Feb 28, 2018

@hayatoito implementations already have this behavior. See the tests I wrote (linked from the PR).

@hayatoito
Copy link
Member

hayatoito commented Feb 28, 2018

Ah, I see. Please forget my previous comment. I thought I forgot to make it composed.

I had updated UI events spec at w3c/uievents#91.
Wasn't that enough?

@annevk
Copy link
Member Author

annevk commented Feb 28, 2018

No, the UI Events specification doesn't really define these events or when they get dispatched. HTML defines that at https://html.spec.whatwg.org/#fire-a-focus-event. I filed w3c/uievents#185 to simply stop defining these in UI Events to make this less confusing.

@hayatoito
Copy link
Member

I got it. Thank you for the explanation.

annevk added a commit that referenced this issue Mar 2, 2018
alice pushed a commit to alice/html that referenced this issue Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: shadow Relates to shadow trees (as defined in DOM)
Development

No branches or pull requests

3 participants