Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fieldset should force used value of 'display' for some values #3915

Closed
zcorpan opened this issue Aug 14, 2018 · 1 comment · Fixed by #3934
Closed

fieldset should force used value of 'display' for some values #3915

zcorpan opened this issue Aug 14, 2018 · 1 comment · Fixed by #3934
Labels
topic: fieldset topic: rendering

Comments

@zcorpan
Copy link
Member

zcorpan commented Aug 14, 2018 •
edited
Loading

Part of #3660

Fieldset needs to override used 'display' for some values.

inline, inline-block, inline-table, ruby, ruby-* -> inline-block
block, table, table-*, list-item, run-in, flow, flow-root -> block

These should work: none, flex, inline-flex, grid, inline-grid, contents, layout() ?
@zcorpan
Copy link
Member Author

zcorpan commented Aug 14, 2018 •
edited
Loading

Tests for grid, inline-grid web-platform-tests/wpt#12477

Tests for flex, inline-flex web-platform-tests/wpt#12489

Tests for blocks and inlines web-platform-tests/wpt#12494

Tests for contents web-platform-tests/wpt#8699

@zcorpan zcorpan mentioned this issue Aug 15, 2018
Open
zcorpan added a commit to web-platform-tests/wpt that referenced this issue Aug 15, 2018
@zcorpan
HTML: fieldset used value for CSS 'display'
08b4701 
See whatwg/html#3915.
@zcorpan zcorpan mentioned this issue Aug 15, 2018
Merged
zcorpan added a commit to web-platform-tests/wpt that referenced this issue Aug 20, 2018
@zcorpan
HTML: fieldset used value for CSS 'display'
1fbb6c1 
See whatwg/html#3915.
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Aug 23, 2018
@zcorpan @moz-wptsync-bot
Bug 1483502 [wpt PR 12494] - HTML: fieldset used value for CSS 'displ…
2ece3de 
…ay', a=testonly

Automatic update from web-platform-testsHTML: fieldset used value for CSS 'display'

See whatwg/html#3915.
--

wpt-commits: 1fbb6c1db6321c617158e2291168e75e1af1d209
wpt-pr: 12494
jankeromnes pushed a commit to jankeromnes/gecko that referenced this issue Aug 23, 2018
@zcorpan @moz-wptsync-bot
Bug 1483502 [wpt PR 12494] - HTML: fieldset used value for CSS 'displ…
c55af88 
…ay', a=testonly

Automatic update from web-platform-testsHTML: fieldset used value for CSS 'display'

See whatwg/html#3915.
--

wpt-commits: 1fbb6c1db6321c617158e2291168e75e1af1d209
wpt-pr: 12494
@zcorpan zcorpan mentioned this issue Aug 24, 2018
Merged
zcorpan added a commit to web-platform-tests/wpt that referenced this issue Aug 27, 2018
@zcorpan
HTML: fieldset used value for CSS 'display'
8b36e14 
See whatwg/html#3915.
zcorpan added a commit that referenced this issue Sep 19, 2018
@zcorpan
Revamp how fieldset and legend rendering is defined
6fbb7ff 
Properly define the rendering of the fieldset and legend elements.

The layout model used is most similar to Gecko, which uses an anonymous box to hold the fieldset's contents.

Fixes #3955, fixes #3930, fixes #3929, fixes #3928, fixes #3927, fixes #3915, fixes #3913, fixes #3660, fixes #3331, fixes #2756, fixes #4013.

Tests:
https://github.com/web-platform-tests/wpt/tree/master/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements
https://github.com/web-platform-tests/wpt/tree/master/html/semantics/forms/the-fieldset-element
mustaqahmed pushed a commit to mustaqahmed/html that referenced this issue Feb 15, 2019
@zcorpan @mustaqahmed
Revamp how fieldset and legend rendering is defined
7c92192 
Properly define the rendering of the fieldset and legend elements.

The layout model used is most similar to Gecko, which uses an anonymous box to hold the fieldset's contents.

Fixes whatwg#3955, fixes whatwg#3930, fixes whatwg#3929, fixes whatwg#3928, fixes whatwg#3927, fixes whatwg#3915, fixes whatwg#3913, fixes whatwg#3660, fixes whatwg#3331, fixes whatwg#2756, fixes whatwg#4013.

Tests:
https://github.com/web-platform-tests/wpt/tree/master/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements
https://github.com/web-platform-tests/wpt/tree/master/html/semantics/forms/the-fieldset-element
mustaqahmed pushed a commit to mustaqahmed/html that referenced this issue Feb 15, 2019
@zcorpan @mustaqahmed
Revamp how fieldset and legend rendering is defined
53d8832 
Properly define the rendering of the fieldset and legend elements.

The layout model used is most similar to Gecko, which uses an anonymous box to hold the fieldset's contents.

Fixes whatwg#3955, fixes whatwg#3930, fixes whatwg#3929, fixes whatwg#3928, fixes whatwg#3927, fixes whatwg#3915, fixes whatwg#3913, fixes whatwg#3660, fixes whatwg#3331, fixes whatwg#2756, fixes whatwg#4013.

Tests:
https://github.com/web-platform-tests/wpt/tree/master/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements
https://github.com/web-platform-tests/wpt/tree/master/html/semantics/forms/the-fieldset-element
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 3, 2019
@marco-c
Bug 1483502 [wpt PR 12494] - HTML: fieldset used value for CSS 'displ…
f779650 
…ay', a=testonly

Automatic update from web-platform-testsHTML: fieldset used value for CSS 'display'

See whatwg/html#3915.
--

wpt-commits: 1fbb6c1db6321c617158e2291168e75e1af1d209
wpt-pr: 12494

UltraBlame original commit: c9a3742b7ec5508b95d194f0aecb7d3d352ff594
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 3, 2019
@marco-c
Bug 1483502 [wpt PR 12494] - HTML: fieldset used value for CSS 'displ…
ace4f10 
…ay', a=testonly

Automatic update from web-platform-testsHTML: fieldset used value for CSS 'display'

See whatwg/html#3915.
--

wpt-commits: 1fbb6c1db6321c617158e2291168e75e1af1d209
wpt-pr: 12494

UltraBlame original commit: c9a3742b7ec5508b95d194f0aecb7d3d352ff594
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 3, 2019
@marco-c
Bug 1483502 [wpt PR 12494] - HTML: fieldset used value for CSS 'displ…
80f54e0 
…ay', a=testonly

Automatic update from web-platform-testsHTML: fieldset used value for CSS 'display'

See whatwg/html#3915.
--

wpt-commits: 1fbb6c1db6321c617158e2291168e75e1af1d209
wpt-pr: 12494

UltraBlame original commit: c9a3742b7ec5508b95d194f0aecb7d3d352ff594
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: fieldset topic: rendering
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revamp how fieldset and legend rendering is defined whatwg/html
1 participant
@zcorpan