Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default box-sizing on <input type=color> #4281

Closed
zcorpan opened this issue Jan 10, 2019 · 3 comments
Closed

Default box-sizing on <input type=color> #4281

zcorpan opened this issue Jan 10, 2019 · 3 comments
Labels
interop Implementations are not interoperable with each other topic: forms topic: rendering

Comments

@zcorpan
Copy link
Member

zcorpan commented Jan 10, 2019 •
edited
Loading

When writing tests for #4143 I noticed that the spec has box-sizing: border-box for buttons in general but not for <input type=color>.

http://software.hixie.ch/utilities/js/live-dom-viewer/saved/6501

WebKit/Chromium have border-box content-box, Gecko/EdgeHTML have content-box border-box.

I suggest we change it to border-box so it's consistent with other buttons.
@zcorpan zcorpan added topic: rendering topic: forms interop Implementations are not interoperable with each other labels Jan 10, 2019
zcorpan added a commit that referenced this issue Jan 10, 2019
@zcorpan
Make input type=color have box-sizing: border-box
107faee 
This matches WebKit/Chromium and is consistent with other buttons.

Fixes #4281.
@zcorpan zcorpan mentioned this issue Jan 10, 2019
Merged
@zcorpan
Copy link
Member Author

zcorpan commented May 14, 2019

WebKit/Chromium have border-box, Gecko/EdgeHTML have content-box.

This was the other way around.

@zcorpan
Copy link
Member Author

zcorpan commented May 14, 2019

https://bugs.chromium.org/p/chromium/issues/detail?id=962927
https://bugs.webkit.org/show_bug.cgi?id=197878

@zcorpan
Copy link
Member Author

zcorpan commented May 15, 2019

This was fixed by #4143

@zcorpan zcorpan closed this as completed May 15, 2019
webkit-commit-queue pushed a commit to WebKit/WebKit that referenced this issue May 5, 2022
@ziransun
<input type=color> should have box-sizing: border-box in UA stylesheet
99e0421 
https://bugs.webkit.org/show_bug.cgi?id=197878

Reviewed by Tim Nguyen.

LayoutTests/imported/w3c:

* web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt:

Source/WebCore:

As discussed at [1], We should have box-sizing: border-box for <input type=color>, the same
as buttons. WebKit currently has content-box. This patch is to change it to box-box.

Since <input type=color> is disabled with WebKitLegacy [2], this fix doesn't apply to it. Hence,
for mac-wk1 platform, the test expectation for html/rendering/non-replaced-elements/form-controls/resets.html
stays as it is.

[1] whatwg/html#4281
[2] https://webkit-search.igalia.com/webkit/source/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml#425-437

* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::colorInputStyleSheet const):
* rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::colorInputStyleSheet const):

LayoutTests:

* platform/glib/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt:
* platform/mac-wk1/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt.

Canonical link: https://commits.webkit.org/250303@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293830 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
interop Implementations are not interoperable with each other topic: forms topic: rendering
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zcorpan