Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Which Document do <script>s delay the load events of? #5160

Closed
domenic opened this issue Dec 17, 2019 · 1 comment · Fixed by #7842
Closed

Which Document do <script>s delay the load events of? #5160

domenic opened this issue Dec 17, 2019 · 1 comment · Fixed by #7842
Labels
needs tests Moving the issue forward requires someone to write tests topic: script

Comments

@domenic
Copy link
Member

domenic commented Dec 17, 2019

I think this Document (of which load event should be delayed) is script's preparation-time document,
which is consistent with that parser-blocking script continue blocking script's preparation-time document.
https://html.spec.whatwg.org/multipage/scripting.html#pending-parsing-blocking-script

Not sure about the browsers' current behavior though (already tested somewhere?)

Originally posted by @hiroshige-g in #5154

Note: the spec currently says the script's "node document" but that is not very precise because the node document can change over time. We should find/write tests to figure out when the document is determined, and then make the spec precise.
@annevk annevk added the needs tests Moving the issue forward requires someone to write tests label Jan 13, 2020
@annevk annevk mentioned this issue Nov 19, 2020
Closed
@hiroshige-g
Copy link
Contributor

I suppose it's preparation-time document, and this is not covered by existing tests (a CL regressing this case passed on Chromium CI).
WPT: web-platform-tests/wpt#33671

Chromium has a bug that async scripts moved to a new Document delays the load event of the new Document (https://bugs.chromium.org/p/chromium/issues/detail?id=1317437) but I expect this should be fixed.

domenic added a commit that referenced this issue Apr 21, 2022
@domenic
Be clearer about documents in script execution
2921b7e 
The only normative change here is to delay the load event of the script's preparation-time document, instead of its node document (which could change while the fetching is in progress). Closes #5160.

Otherwise, this consists of cleanups to use more precise language for certain documents, thus closing #7589, and of the pending parsing-blocking script concept to use more imperative language.
@domenic domenic mentioned this issue Apr 21, 2022
Merged
3 tasks
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Apr 21, 2022
@hiroshige-g @chromium-wpt-export-bot
[WPT] ordering/delay-the-load-event around scripts moved between Docu…
249ec0b 
…ments

Bug: 1303648, 1317437, whatwg/html#5160
Change-Id: I83c8fc73804eb5c4de1508947fd1415cae3c3bcd
Merged
aarongable pushed a commit to chromium/chromium that referenced this issue Apr 21, 2022
@hiroshige-g
[WPT] ordering/delay-the-load-event around scripts moved between Docu…
f12b942 
…ments

Bug: 1303648, 1317437, whatwg/html#5160
Change-Id: I83c8fc73804eb5c4de1508947fd1415cae3c3bcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3508112
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994917}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Apr 21, 2022
@hiroshige-g @chromium-wpt-export-bot
[WPT] ordering/delay-the-load-event around scripts moved between Docu…
a7b283e 
…ments

Bug: 1303648, 1317437, whatwg/html#5160
Change-Id: I83c8fc73804eb5c4de1508947fd1415cae3c3bcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3508112
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994917}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Apr 21, 2022
@hiroshige-g @chromium-wpt-export-bot
[WPT] ordering/delay-the-load-event around scripts moved between Docu…
d533110 
…ments

Bug: 1303648, 1317437, whatwg/html#5160
Change-Id: I83c8fc73804eb5c4de1508947fd1415cae3c3bcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3508112
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994917}
domenic added a commit that referenced this issue Apr 26, 2022
@domenic
Be clearer about documents in script execution
60a9ea1 
The only normative change here is to delay the load event of the script's preparation-time document, instead of its node document (which could change while the fetching is in progress). Closes #5160.

Otherwise, this consists of cleanups to use more precise language for certain documents, thus closing #7589, and of the pending parsing-blocking script concept to use more imperative language.
DanielRyanSmith pushed a commit to DanielRyanSmith/wpt that referenced this issue Apr 27, 2022
@hiroshige-g @DanielRyanSmith
[WPT] ordering/delay-the-load-event around scripts moved between Docu…
21adf48 
…ments

Bug: 1303648, 1317437, whatwg/html#5160
Change-Id: I83c8fc73804eb5c4de1508947fd1415cae3c3bcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3508112
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994917}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 16, 2022
@hiroshige-g @moz-wptsync-bot
Bug 1765219 [wpt PR 33671] - [WPT] ordering/delay-the-load-event arou…
4fe7a4b 
…nd scripts moved between Documents, a=testonly

Automatic update from web-platform-tests
[WPT] ordering/delay-the-load-event around scripts moved between Documents

Bug: 1303648, 1317437, whatwg/html#5160
Change-Id: I83c8fc73804eb5c4de1508947fd1415cae3c3bcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3508112
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994917}

--

wpt-commits: d533110f00fa6250e1ebbe46a23d2d2e3f70df1e
wpt-pr: 33671
jamienicol pushed a commit to jamienicol/gecko that referenced this issue May 25, 2022
@hiroshige-g @moz-wptsync-bot
Bug 1765219 [wpt PR 33671] - [WPT] ordering/delay-the-load-event arou…
39bed54 
…nd scripts moved between Documents, a=testonly

Automatic update from web-platform-tests
[WPT] ordering/delay-the-load-event around scripts moved between Documents

Bug: 1303648, 1317437, whatwg/html#5160
Change-Id: I83c8fc73804eb5c4de1508947fd1415cae3c3bcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3508112
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/main@{#994917}

--

wpt-commits: d533110f00fa6250e1ebbe46a23d2d2e3f70df1e
wpt-pr: 33671
mfreed7 pushed a commit to mfreed7/html that referenced this issue Jun 3, 2022
@domenic @mfreed7
Be clearer about documents in script execution
c470aaa 
The only normative change here is to delay the load event of the script's preparation-time document, instead of its node document (which could change while the fetching is in progress). Closes whatwg#5160.

Otherwise, this consists of cleanups to use more precise language for certain documents, thus closing whatwg#7589, and of the pending parsing-blocking script concept to use more imperative language.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs tests Moving the issue forward requires someone to write tests topic: script
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Be clearer about documents in script execution whatwg/html
3 participants
@domenic @annevk @hiroshige-g