Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schemelessly same site's algorithm appears to have a typo #5281

Closed
sbingler opened this issue Feb 12, 2020 · 1 comment · Fixed by #5287
Closed

Schemelessly same site's algorithm appears to have a typo #5281

sbingler opened this issue Feb 12, 2020 · 1 comment · Fixed by #5287

Comments

@sbingler
Copy link

Step 2.2 in the schemelessly same site algorithm states
"If hostA equal hostB, and hostA's registrable domain is non-null, then return true."

This step seems as if it would make more sense if it were instead
"If hostA equal hostB, and hostA's registrable domain is null, then return true."
@sbingler
Copy link
Author

For example: if the origins are both the same IP address they should be same site with each other.

annevk added a commit that referenced this issue Feb 13, 2020
@annevk
Ensure schemelessly same-site handles non-domains well
017e8ef 
Fixes #5281.
@annevk annevk mentioned this issue Feb 13, 2020
Merged
annevk added a commit that referenced this issue Feb 14, 2020
@annevk
Ensure schemelessly same-site handles non-domains well
4970db0 
Fixes #5281.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure schemelessly same-site handles non-domains well whatwg/html
1 participant
@sbingler