Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML cross-document encoding inheritance with bogus Content-Type charset #8789

Open
annevk opened this issue Jan 27, 2023 · 1 comment
Open
Labels
interop Implementations are not interoperable with each other topic: parser

Comments

@annevk
Copy link
Member

annevk commented Jan 27, 2023

It appears that in Chromium and WebKit, cross-document encoding inheritance is off the table once there is a bogus charset parameter value seen in a Content-Type header: web-platform-tests/wpt#38199.

Gecko does this correctly so perhaps this is simply something to be fixed, but I worry a bit about compatibility.

The behavior is a bit strange though as there is fallback from Content-Type to <meta>, but cross-document is off the table. (Tests don't directly show it, but bogus Content-Type and bogus <meta charset> also don't lead to inheritance.)

@mfreed7 @rniwa thoughts?

cc @hsivonen @smaug----

@annevk annevk added topic: parser interop Implementations are not interoperable with each other labels Jan 27, 2023
annevk added a commit to web-platform-tests/wpt that referenced this issue Jan 27, 2023
Make Encoding tests no longer rely on an interoperability issue and simultaneously add tests for that issue. The latter tests align with the HTML Standard, but that might not necessarily be the path we want to take.

whatwg/html#8789 can be used for further discussion.
annevk added a commit to web-platform-tests/wpt that referenced this issue Apr 4, 2023
Make Encoding tests no longer rely on an interoperability issue and simultaneously add tests for that issue. The latter tests align with the HTML Standard, but that might not necessarily be the path we want to take.

whatwg/html#8789 can be used for further discussion.
cookiecrook pushed a commit to cookiecrook/wpt that referenced this issue Apr 8, 2023
Make Encoding tests no longer rely on an interoperability issue and simultaneously add tests for that issue. The latter tests align with the HTML Standard, but that might not necessarily be the path we want to take.

whatwg/html#8789 can be used for further discussion.
@annevk annevk added the agenda+ To be discussed at a triage meeting label Apr 14, 2023
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Apr 15, 2023
…nheritance , a=testonly

Automatic update from web-platform-tests
Encoding/HTML: cross-document encoding inheritance

Make Encoding tests no longer rely on an interoperability issue and simultaneously add tests for that issue. The latter tests align with the HTML Standard, but that might not necessarily be the path we want to take.

whatwg/html#8789 can be used for further discussion.
--

wpt-commits: a58bbf6d8c0db1f1fd5352e846acb0754ee55567
wpt-pr: 38199
@past past removed the agenda+ To be discussed at a triage meeting label Jun 2, 2023
@hsivonen
Copy link
Member

hsivonen commented Jul 5, 2023

Doing it the Gecko&spec way is more consistent: On every level, bogosity and absence work the same. I'm not aware of any Web compat bugs caused by following the spec.

Having to track the bogosity of Content-Type would involve passing around an extra bit of state, which seems like a sad extra bit of complexity in the absence of a compelling Web compat need to do it that way.

Regarding the meeting notes: Even though this is 2/3 in terms of counting places to patch, this seems really 1/2 in terms of independent implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interop Implementations are not interoperable with each other topic: parser
Development

No branches or pull requests

3 participants