Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide all popovers when beforetoggle shows a popover #10015

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Hide all popovers when beforetoggle shows a popover #10015

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c998f3
Hide all popovers when beforetoggle shows a popover
josepharhar Dec 20, 2023
e231434
s/this/element
josepharhar Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84360,6 +84360,10 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
</ol>
</li>

<li><p>Let <var>autoPopoverListContainsElement</var> be true if <var>document</var>'s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: it seems weird for this to end in "This" when there's no this in this algorithm.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it from "this" to "element"

<span>showing auto popover list</span>'s last item is <var>element</var>, otherwise
false.</p></li>

<li><p>Set <var>element</var>'s <span>popover invoker</span> to null.</p></li>

<li>
Expand All @@ -84372,6 +84376,11 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
data-x="">open</code>" and the <code data-x="dom-ToggleEvent-newState">newState</code>
attribute initialized to "<code data-x="">closed</code>" at <var>element</var>.</p></li>

<li><p>If <var>autoPopoverListContainsElement</var> is true and <var>document</var>'s
<span>showing auto popover list</span>'s last item is not <var>element</var>, then run <span
data-x="hide-all-popovers-until">hide all popovers until</span> given <var>element</var>,
<var>focusPreviousElement</var>, and false.</p></li>

<li>
<p>If the result of running <span>check popover validity</span> given <var>element</var>,
true, <var>throwExceptions</var>, and null is false, then run <var>cleanupSteps</var> and
Expand Down Expand Up @@ -84451,6 +84460,10 @@ dictionary <dfn dictionary>DragEventInit</dfn> : <span>MouseEventInit</span> {
<var>focusPreviousElement</var>, and a boolean <var>fireEvents</var>:</p>

<ol>
<li><p>If <var>endpoint</var> is an <span data-x="HTML elements">HTML element</span> and
<var>endpoint</var> is not in the <span data-x="popover-showing-state">popover showing
state</span>, then return.</p></li>

<li><p>Let <var>document</var> be <var>endpoint</var>'s <span>node document</span>.</p></li>

<li>
Expand Down
Loading