Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rendering: define progress, meter, range input's value layout with vertical writing-mode to support direction #10096

Merged
merged 8 commits into from
Mar 4, 2024
Merged

Rendering: define progress, meter, range input's value layout with vertical writing-mode to support direction #10096

merged 8 commits into from
Mar 4, 2024

Conversation

dizhang168
Copy link
Contributor

@dizhang168 dizhang168 commented Jan 26, 2024 •
edited by pr-preview bot
Loading

This covers:
Allowing directionltr and rtl to affect how a form control with vertical writing-mode is rendered. For elements <progress>, <meter>, <input type=range> with vertical writing-mode:

  • If direction is ltr, value is rendered top to bottom.
  • If direction is rtl, value is rendered bottom to top.

Issue: #8413
Related Issue: #4177

(See WHATWG Working Mode: Changes for more details.)

/acknowledgements.html ( diff )
/index.html ( diff )
/infrastructure.html ( diff )
/input.html ( diff )
/rendering.html ( diff )

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 26, 2024
@dizhang168 @chromium-wpt-export-bot
Add WPT tests for WM vertical and direction RTL for progress, meter, …
a45afa3 
…range

Per HTML spec PR, we should add more WPT tests to cover <meter> and
<progress> cases.
whatwg/html#10096

Change-Id: I29afd2d6ff47a4651540904231613f0f8925dbd4
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Jan 26, 2024
Merged
aarongable pushed a commit to chromium/chromium that referenced this pull request Jan 29, 2024
@dizhang168
Add WPT tests for WM vertical and direction RTL for progress, meter, …
487c8ba 
…range

Per HTML spec PR, we should add more WPT tests to cover <meter> and
<progress> cases.
whatwg/html#10096

Change-Id: I29afd2d6ff47a4651540904231613f0f8925dbd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5241236
Auto-Submit: Di Zhang <dizhangg@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1253403}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 29, 2024
@dizhang168 @chromium-wpt-export-bot
Add WPT tests for WM vertical and direction RTL for progress, meter, …
91150bc 
…range

Per HTML spec PR, we should add more WPT tests to cover <meter> and
<progress> cases.
whatwg/html#10096

Change-Id: I29afd2d6ff47a4651540904231613f0f8925dbd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5241236
Auto-Submit: Di Zhang <dizhangg@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1253403}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jan 29, 2024
@dizhang168 @chromium-wpt-export-bot
Add WPT tests for WM vertical and direction RTL for progress, meter, …
7f56fee 
…range

Per HTML spec PR, we should add more WPT tests to cover <meter> and
<progress> cases.
whatwg/html#10096

Change-Id: I29afd2d6ff47a4651540904231613f0f8925dbd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5241236
Auto-Submit: Di Zhang <dizhangg@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1253403}
mfreed7
mfreed7 reviewed Jan 30, 2024
View reviewed changes
source Outdated Show resolved Hide resolved
@domenic
Copy link
Member

domenic commented Jan 31, 2024

I'm a bit confused; this PR title mentions vertical writing mode, but the PR changes don't mention writing mode at all. They just make the existing paradigm (based on the width vs. height) change depending on 'direction'.

dizhang168
dizhang168 commented Feb 1, 2024
View reviewed changes
source Show resolved Hide resolved
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 2, 2024
@dizhang168 @moz-wptsync-bot
Bug 1876863 [wpt PR 44241] - Add WPT tests for WM vertical and direct…
0279558 
…ion RTL for progress, meter, range, a=testonly

Automatic update from web-platform-tests
Add WPT tests for WM vertical and direction RTL for progress, meter, range

Per HTML spec PR, we should add more WPT tests to cover <meter> and
<progress> cases.
whatwg/html#10096

Change-Id: I29afd2d6ff47a4651540904231613f0f8925dbd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5241236
Auto-Submit: Di Zhang <dizhangg@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1253403}

--

wpt-commits: 7f56feea538b986d5681532c0dcba8c9773cd6c4
wpt-pr: 44241
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this pull request Feb 2, 2024
@dizhang168 @moz-wptsync-bot
Bug 1876863 [wpt PR 44241] - Add WPT tests for WM vertical and direct…
2a4ce39 
…ion RTL for progress, meter, range, a=testonly

Automatic update from web-platform-tests
Add WPT tests for WM vertical and direction RTL for progress, meter, range

Per HTML spec PR, we should add more WPT tests to cover <meter> and
<progress> cases.
whatwg/html#10096

Change-Id: I29afd2d6ff47a4651540904231613f0f8925dbd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5241236
Auto-Submit: Di Zhang <dizhangg@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1253403}

--

wpt-commits: 7f56feea538b986d5681532c0dcba8c9773cd6c4
wpt-pr: 44241
@dizhang168
Copy link
Contributor Author

Since in this PR I am adding details on how CSS property writing-mode affects sliders, I wonder if we should also update the specs for other form controls that supports vertical writing-mode. For example, select, buttons, text-based inputs, textarea, etc.

Reviewers, let me know what you think. That can be a separate PR too.

domenic
domenic reviewed Feb 6, 2024
View reviewed changes
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Show resolved Hide resolved
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Feb 8, 2024
@marco-c
Bug 1876863 [wpt PR 44241] - Add WPT tests for WM vertical and direct…
3045612 
…ion RTL for progress, meter, range, a=testonly

Automatic update from web-platform-tests
Add WPT tests for WM vertical and direction RTL for progress, meter, range

Per HTML spec PR, we should add more WPT tests to cover <meter> and
<progress> cases.
whatwg/html#10096

Change-Id: I29afd2d6ff47a4651540904231613f0f8925dbd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5241236
Auto-Submit: Di Zhang <dizhanggchromium.org>
Commit-Queue: Joey Arhar <jarharchromium.org>
Reviewed-by: Joey Arhar <jarharchromium.org>
Cr-Commit-Position: refs/heads/main{#1253403}

--

wpt-commits: 7f56feea538b986d5681532c0dcba8c9773cd6c4
wpt-pr: 44241

UltraBlame original commit: 919e208673c7abc23ef1b53a5ec5c67d10d2726c
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Feb 8, 2024
@marco-c
Bug 1876863 [wpt PR 44241] - Add WPT tests for WM vertical and direct…
6d981ca 
…ion RTL for progress, meter, range, a=testonly

Automatic update from web-platform-tests
Add WPT tests for WM vertical and direction RTL for progress, meter, range

Per HTML spec PR, we should add more WPT tests to cover <meter> and
<progress> cases.
whatwg/html#10096

Change-Id: I29afd2d6ff47a4651540904231613f0f8925dbd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5241236
Auto-Submit: Di Zhang <dizhanggchromium.org>
Commit-Queue: Joey Arhar <jarharchromium.org>
Reviewed-by: Joey Arhar <jarharchromium.org>
Cr-Commit-Position: refs/heads/main{#1253403}

--

wpt-commits: 7f56feea538b986d5681532c0dcba8c9773cd6c4
wpt-pr: 44241

UltraBlame original commit: 919e208673c7abc23ef1b53a5ec5c67d10d2726c
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Feb 8, 2024
@marco-c
Bug 1876863 [wpt PR 44241] - Add WPT tests for WM vertical and direct…
7d6f606 
…ion RTL for progress, meter, range, a=testonly

Automatic update from web-platform-tests
Add WPT tests for WM vertical and direction RTL for progress, meter, range

Per HTML spec PR, we should add more WPT tests to cover <meter> and
<progress> cases.
whatwg/html#10096

Change-Id: I29afd2d6ff47a4651540904231613f0f8925dbd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5241236
Auto-Submit: Di Zhang <dizhanggchromium.org>
Commit-Queue: Joey Arhar <jarharchromium.org>
Reviewed-by: Joey Arhar <jarharchromium.org>
Cr-Commit-Position: refs/heads/main{#1253403}

--

wpt-commits: 7f56feea538b986d5681532c0dcba8c9773cd6c4
wpt-pr: 44241

UltraBlame original commit: 919e208673c7abc23ef1b53a5ec5c67d10d2726c
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this pull request Feb 23, 2024
@dizhang168 @marcoscaceres
Add WPT tests for WM vertical and direction RTL for progress, meter, …
1e8790e 
…range

Per HTML spec PR, we should add more WPT tests to cover <meter> and
<progress> cases.
whatwg/html#10096

Change-Id: I29afd2d6ff47a4651540904231613f0f8925dbd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5241236
Auto-Submit: Di Zhang <dizhangg@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1253403}
domenic
domenic reviewed Feb 29, 2024
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for letting this lapse for some time. Only editorial issues remaining.

source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
@domenic domenic merged commit 702119c into whatwg:main Mar 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfreed7 mfreed7 mfreed7 left review comments

@yisibl yisibl yisibl left review comments

@annevk annevk annevk left review comments

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
topic: rendering
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dizhang168 @domenic @annevk @yisibl @mfreed7