Support automatic user prompt handing in WebDriver BiDi #10189
Conversation
jgraham
force-pushed
the
prompt_handler
branch
2 times, most recently
from
06090d4
to
bb7b60e
Compare
Well it does, on the assumption that none/accept/dismiss are the only available options. In that case "dismiss" is what happens when the return value is neither "none" nor "accept". I think for |
This reads the return value from the WebDriver BiDi user prompt opened algorithm and uses it to decide whether to show the prompt, or skip showing it but act as if it had been accepted or canceled. At present the prompt opened function can return three values: "none", which causes the prompt to be displayed, "accept", which acts as if the prompt was accepted, and "dismiss" which acts as if the prompt was rejected. The WebDriver side is responsible for ensuring that only valid responses are sent for each prompt type (e.g. for an alert there isn't a "dismiss" option).
|
@jgraham is that PR ready for a general review now? |
|
Yes, as far as I'm concerned this can be reviewed. |
|
@domenic would you have a chance to review this PR? Thanks! |
|
I pushed some editorial nits. My main question is whether it makes sense to always show the prompt in the way you have specified, or if you should avoid showing the prompt if userPromptHandler is "none". The latter makes more sense to me, but isn't the approach you've taken here; instead, you always show the prompts, but only pause for user input in some cases. |
|
A user prompt handler of "none" means "no handler", not "no prompt". So in that case we still need to show the prompt so that a user can interact with it. |
This reads the return value from the WebDriver BiDi user prompt opened algorithm and uses it to decide whether to show the prompt, or skip showing it but act as if it had been accepted or canceled.
At present the prompt opened function can return three values: "none", which causes the prompt to be displayed, "accept", which acts as if the prompt was accepted, and "dismiss" which acts as if the prompt was rejected. The WebDriver side is responsible for ensuring that only valid responses are sent for each prompt type (e.g. for an alert there isn't a "dismiss" option).
(See WHATWG Working Mode: Changes for more details.)
/browsing-the-web.html ( diff )
/timers-and-user-prompts.html ( diff )