Pass parser metadata to Fetch #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but prefer a LGTM2 from @domenic. |
|
Is it correct that classic workers should have the empty string as their parser metadata, instead of "not-parser-inserted"? |
In order for CSP to correctly implement the 'unsafe-dynamic' source expression, HTML needs to teach Fetch about the parser-insertedness that ought to be associated with script requests. See w3c/webappsec-csp#70 for context. The Fetch side of this patch is whatwg/fetch#285.
|
Thanks! a18d716 should take care of that oversight. |
| @@ -86819,7 +86835,9 @@ interface <dfn>NavigatorOnLine</dfn> { | |||
| data-x="concept-request-referrer">referrer</span> is <var>referrer</var>, <span | |||
| data-x="concept-request-mode">mode</span> is "<code data-x="">same-origin</code>", <span | |||
| data-x="concept-request-credentials-mode">credentials mode</span> is "<code | |||
| data-x="">same-origin</code>", and whose <span>use-URL-credentials flag</span> is set.</p></li> | |||
| data-x="">same-origin</code>", <span data-x="concept-request-parser-metadata">parser | |||
| metadata</span> is "<code title>not parser-inserted</code>", and whose <span>use-URL-credentials | |||
There was a problem hiding this comment.
title -> data-x="" (I got a parse error here)
There was a problem hiding this comment.
Fixed. Sorry... I should have built before uploading, but it seemed so simple! :)
|
\o/ |
|
Thanks. :) |
mikewest
added a commit
to w3c/webappsec-csp
that referenced
this pull request
Apr 15, 2016
Thanks to @annevk in whatwg/html#1048
ryandel8834
added a commit
to ryandel8834/WebAppSec-CSP
that referenced
this pull request
Aug 13, 2022
ryandel8834
added a commit
to ryandel8834/WebAppSec-CSP
that referenced
this pull request
Aug 13, 2022
Thanks to @annevk in whatwg/html#1048
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for CSP to correctly implement the 'unsafe-dynamic' source
expression, HTML needs to teach Fetch about the parser-insertedness
that ought to be associated with script requests.
See w3c/webappsec-csp#70 for context.
The Fetch side of this patch is whatwg/fetch#285.