Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mutation events from the spec #10573

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Remove mutation events from the spec #10573

merged 2 commits into from
Aug 26, 2024

Conversation

mfreed7
Copy link
Contributor

@mfreed7 mfreed7 commented Aug 21, 2024 •
edited by pr-preview bot
Loading

The html spec only mentioned mutation events a handful of times, but now that they have been removed from some browsers it feels safe to remove these mentions from the spec.

Closes whatwg/dom#305

/common-dom-interfaces.html ( diff )
/dom.html ( diff )
/dynamic-markup-insertion.html ( diff )
/interactive-elements.html ( diff )
/parsing.html ( diff )
/xhtml.html ( diff )

@mfreed7
Remove mutation events from the spec
34ab8d8 
The html spec only mentioned mutation events a handful of times,
but now that they [have been removed from some browsers](whatwg/dom#305 (comment))
it feels safe to remove these mentions from the spec.
@mfreed7 mfreed7 mentioned this pull request Aug 21, 2024
Open
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 21, 2024
@mfreed7 @chromium-wpt-export-bot
Add mutation events to "historical" WPT
62839b5 
This set of tests goes along with this spec PR:

  whatwg/html#10573

Bug: 40268638
Change-Id: I39aafcc0ec1f36704cdc3a263c798c1873333b11
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Aug 21, 2024
Merged
aarongable pushed a commit to chromium/chromium that referenced this pull request Aug 21, 2024
@mfreed7
Add mutation events to "historical" WPT
2e88b1e 
This set of tests goes along with this spec PR:

  whatwg/html#10573

Bug: 40268638
Change-Id: I39aafcc0ec1f36704cdc3a263c798c1873333b11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5803663
Reviewed-by: David Baron <dbaron@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1345088}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 21, 2024
@mfreed7 @chromium-wpt-export-bot
Add mutation events to "historical" WPT
07904e6 
This set of tests goes along with this spec PR:

  whatwg/html#10573

Bug: 40268638
Change-Id: I39aafcc0ec1f36704cdc3a263c798c1873333b11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5803663
Reviewed-by: David Baron <dbaron@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1345088}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 21, 2024
@mfreed7 @chromium-wpt-export-bot
Add mutation events to "historical" WPT
e0c3477 
This set of tests goes along with this spec PR:

  whatwg/html#10573

Bug: 40268638
Change-Id: I39aafcc0ec1f36704cdc3a263c798c1873333b11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5803663
Reviewed-by: David Baron <dbaron@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1345088}
domenic
domenic approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM with nit.

I'll give others a few days to comment as well.

source Outdated Show resolved Hide resolved
annevk
annevk reviewed Aug 22, 2024
View reviewed changes
source Show resolved Hide resolved
source Show resolved Hide resolved
mfreed7
mfreed7 commented Aug 23, 2024
View reviewed changes
Copy link
Contributor Author

@mfreed7 mfreed7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

source Show resolved Hide resolved
source Show resolved Hide resolved
source Outdated Show resolved Hide resolved
@mfreed7
Copy link
Contributor Author

mfreed7 commented Aug 23, 2024

[ ] Implementation bugs are filed:

Given your good point about origin trials and dates, do you think I should just hold off on filing implementation bugs?

annevk
annevk reviewed Aug 23, 2024
View reviewed changes
source
.</p>



Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it removes too many newlines, but maybe it makes it more consistent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's kind of why I removed those - they seemed extra. I can put them back if you tell me how many blank lines would be correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One day we will have automatic formatting for newlines before headings, but until we do, the document is very inconsistent, so I'm OK to merge without fixing this.

@annevk
Copy link
Member

annevk commented Aug 23, 2024

Yeah, I think Gecko and WebKit can get an implementation bug when we decide the whatwg/dom issue is good. Gecko might also already have one. I think it's still okay to merge this given that it's highly likely going to succeed and given that mutation events weren't much specified to begin with.

@mfreed7
Copy link
Contributor Author

mfreed7 commented Aug 23, 2024

Yeah, I think Gecko and WebKit can get an implementation bug when we decide the whatwg/dom issue is good. Gecko might also already have one. I think it's still okay to merge this given that it's highly likely going to succeed and given that mutation events weren't much specified to begin with.

Sounds good, thanks!

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Aug 23, 2024
@mfreed7 @moz-wptsync-bot
Bug 1914289 [wpt PR 47727] - Add mutation events to "historical" WPT,…
8de4aad 
… a=testonly

Automatic update from web-platform-tests
Add mutation events to "historical" WPT

This set of tests goes along with this spec PR:

  whatwg/html#10573

Bug: 40268638
Change-Id: I39aafcc0ec1f36704cdc3a263c798c1873333b11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5803663
Reviewed-by: David Baron <dbaron@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1345088}

--

wpt-commits: e0c3477d2cff8aaaefd421ca6543198ec30dc3ef
wpt-pr: 47727
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request Aug 24, 2024
@mfreed7 @moz-wptsync-bot
Bug 1914289 [wpt PR 47727] - Add mutation events to "historical" WPT,…
af519bc 
… a=testonly

Automatic update from web-platform-tests
Add mutation events to "historical" WPT

This set of tests goes along with this spec PR:

  whatwg/html#10573

Bug: 40268638
Change-Id: I39aafcc0ec1f36704cdc3a263c798c1873333b11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5803663
Reviewed-by: David Baron <dbaron@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1345088}

--

wpt-commits: e0c3477d2cff8aaaefd421ca6543198ec30dc3ef
wpt-pr: 47727
@domenic domenic merged commit 9a01ce8 into whatwg:main Aug 26, 2024
2 checks passed
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this pull request Aug 26, 2024
@mfreed7 @moz-wptsync-bot
Bug 1914289 [wpt PR 47727] - Add mutation events to "historical" WPT,…
eb5d200 
… a=testonly

Automatic update from web-platform-tests
Add mutation events to "historical" WPT

This set of tests goes along with this spec PR:

  whatwg/html#10573

Bug: 40268638
Change-Id: I39aafcc0ec1f36704cdc3a263c798c1873333b11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5803663
Reviewed-by: David Baron <dbaron@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1345088}

--

wpt-commits: e0c3477d2cff8aaaefd421ca6543198ec30dc3ef
wpt-pr: 47727
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk left review comments

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define mutation events
3 participants
@mfreed7 @annevk @domenic