use the afterRemoval steps to clean up implicit anchors #11695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #11694 w3c/csswg-drafts#12850
Removing the implicit anchor element should always happen on hide. Chrome removes this during "remove from top layer immediately" which is not to spec (those steps do not remove implicit anchors). If an implementation was written to spec as it is now, then anchors would not properly be cleaned up.
What needs to happen is it needs to be cleaned up regardless of the
fireEvents
value. But also, as #11694 describes, animation timing should be taken into account. The csswg spec affords for animation timing for theoverlay
property, but not for other actions. w3c/csswg-drafts#12850 introduces a callback to these steps which we can then use here to clean up the implicit anchor at the right time.(See WHATWG Working Mode: Changes for more details.)
/popover.html ( diff )