-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: Cross-reference DOM "child" where appropriate in rendering #1799
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits. Will let you decide whether to merge now or wait to see how the discussion on the mailing lists turns out.
@@ -3143,6 +3143,7 @@ a.setAttribute('href', 'http://example.com/'); // change the content attribute d | |||
|
|||
<li>The <dfn data-noexport="" data-x-href="https://dom.spec.whatwg.org/#concept-tree">tree</dfn> and <dfn data-noexport="" data-x-href="https://dom.spec.whatwg.org/#concept-shadow-tree">shadow tree</dfn> concepts</li> | |||
<li>The <dfn data-x-href="https://dom.spec.whatwg.org/#concept-tree-order">tree order</dfn> and <dfn data-x-href="https://dom.spec.whatwg.org/#concept-shadow-including-tree-order">shadow-including tree order</dfn> concepts</li> | |||
<li>The <dfn data-noexport="" data-x-href="https://dom.spec.whatwg.org/#concept-tree-child" data-x="concept-tree-child">child</dfn> concept</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data-noexport not necessary; we've just been cargo-culting it.
|
||
<ul class="brief"> | ||
|
||
<li>The child is a <code>legend</code> element.</li> | ||
|
||
<li>The child is not <span>out-of-flow</span> (e.g. not absolutely positioned or floated).</li> | ||
|
||
<li>The child is generating a box (e.g. it is not 'display:none').</li> | ||
<li>The child is generating a box (e.g. it is not 'display:none' or 'display:contents').</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also mention this in the commit message
The ruby/colgroup parts are simply nonsense, imo. The HTML spec should simply define the default UA styling for those (setting the If I style my |
Fixes https://lists.w3.org/Archives/Public/public-whatwg-archive/2016Sep/0013.html
cc @fantasai @bzbarsky
Instances of "child" in the rendering section that I did not cross-reference DOM child:
Since these are talking about CSS model I suppose children here are referring to the CSS concept of children, but I'm not entirely sure.