Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Cross-reference DOM "child" where appropriate in rendering #1799

Merged
merged 3 commits into from
Sep 20, 2016

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Sep 20, 2016

Fixes https://lists.w3.org/Archives/Public/public-whatwg-archive/2016Sep/0013.html


cc @fantasai @bzbarsky

Instances of "child" in the rendering section that I did not cross-reference DOM child:

  <p>For the purposes of the CSS ruby model, runs of children of <code>ruby</code> elements that are
  not <code>rt</code> or <code>rp</code> elements are expected to be wrapped in anonymous boxes
  whose <span>'display'</span> property has the value <span>'ruby-base'</span>. <ref
  spec=CSSRUBY></p>
  <p>For the purposes of the CSS table model, the <code>colgroup</code> element, if it contains no
  <code>col</code> element, is expected to be treated as if it had as many such children as its
  <code data-x="attr-colgroup-span">span</code> attribute <span data-x="rules for parsing non-negative
  integers">specifies</span>.</p>

Since these are talking about CSS model I suppose children here are referring to the CSS concept of children, but I'm not entirely sure.

@zcorpan zcorpan added clarification Standard could be clearer topic: rendering labels Sep 20, 2016
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits. Will let you decide whether to merge now or wait to see how the discussion on the mailing lists turns out.

@@ -3143,6 +3143,7 @@ a.setAttribute('href', 'http://example.com/'); // change the content attribute d

<li>The <dfn data-noexport="" data-x-href="https://dom.spec.whatwg.org/#concept-tree">tree</dfn> and <dfn data-noexport="" data-x-href="https://dom.spec.whatwg.org/#concept-shadow-tree">shadow tree</dfn> concepts</li>
<li>The <dfn data-x-href="https://dom.spec.whatwg.org/#concept-tree-order">tree order</dfn> and <dfn data-x-href="https://dom.spec.whatwg.org/#concept-shadow-including-tree-order">shadow-including tree order</dfn> concepts</li>
<li>The <dfn data-noexport="" data-x-href="https://dom.spec.whatwg.org/#concept-tree-child" data-x="concept-tree-child">child</dfn> concept</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data-noexport not necessary; we've just been cargo-culting it.


<ul class="brief">

<li>The child is a <code>legend</code> element.</li>

<li>The child is not <span>out-of-flow</span> (e.g. not absolutely positioned or floated).</li>

<li>The child is generating a box (e.g. it is not 'display:none').</li>
<li>The child is generating a box (e.g. it is not 'display:none' or 'display:contents').</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also mention this in the commit message

@bzbarsky
Copy link
Contributor

The ruby/colgroup parts are simply nonsense, imo. The HTML spec should simply define the default UA styling for those (setting the display) property and say nothing else. I guess you still have to define what span means on colgroup, but that should be restricted to cases when the colgroup is in fact styled as a colgroup, and should explicitly talk about child table-column boxes somewhere, not child elements.

If I style my <colgroup> as display: table-row-group then none of the stuff quoted above should apply, of course.

@zcorpan
Copy link
Member Author

zcorpan commented Sep 20, 2016

Thanks, we'll track ruby/colgroup in #121 and #1800, respectively.

@zcorpan zcorpan merged commit e8c91c0 into master Sep 20, 2016
@zcorpan zcorpan deleted the clarify-fieldset-rendering branch September 20, 2016 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Standard could be clearer topic: rendering
Development

Successfully merging this pull request may close these issues.

3 participants