Snapshot the allowpaymentrequest attribute #2195

zcorpan · 2016-12-20T08:42:57Z

New allow* attributes should use the snapshot model used by <iframe sandbox>
and Feature Policy. The allowfullscreen and allowusermedia attributes are
left with their current live behavior in this change, because it is not yet
clear if it is Web-compatible to change them (see #2187).

Part of #2143.

New allow* attributes should use the snapshot model used by <iframe sandbox> and Feature Policy. The allowfullscreen and allowusermedia attributes are left with their current live behavior in this change, because it is not yet clear if it is Web-compatible to change them (see #2187). Part of #2143.

Test for whatwg/html#2195

zcorpan · 2016-12-20T13:07:45Z

Tests: web-platform-tests/wpt#4369

zcorpan · 2016-12-20T14:22:50Z

cc @rsolomakhin

zcorpan · 2016-12-20T14:36:11Z

source

+     <p>Otherwise, follow these substeps:</p>
+
+     <ol>
+      <li><p>If <var>document</var> has the <var><var>allowattribute</var> flag</var> set, and


The nested var here is maybe a bit unclear? Any ideas? Adding "«" and "»" before/after with CSS helps I think...

Wasn't it <var>allow<var>attribute</var> flag</var> elsewhere? That was reasonbly clear I thought.

I guess I was misremembering. Some CSS solution is probably good; not sure I'd use those quotes though since we use them to denote Infra lists.

whatwg/resources.whatwg.org#38

See whatwg/html#2195 (comment)

zcorpan · 2016-12-23T10:08:51Z

source

@@ -28485,7 +28485,9 @@ interface <dfn>HTMLIFrameElement</dfn> : <span>HTMLElement</span> {
  has a <span>nested browsing context</span>, the user agent must <span data-x="parse a sandboxing
  directive">parse the sandboxing directive</span> using the attribute's value as the
  <var>input</var> and the <code>iframe</code> element's <span>nested browsing context</span>'s
-  <span><code>iframe</code> sandboxing flag set</span> as the output.</p>
+  <span><code>iframe</code> sandboxing flag set</span> as the output. If the <code>iframe</code> has
+  an <code data-x="attr-iframe-allowpaymentrequest">allowpaymentrequest</code> attribute, then set


Hmm, I put this here because it was here in 9f6b91c but this doesn't make sense. It needs to be in https://html.spec.whatwg.org/#initialise-the-document-object I think.

edit: and https://html.spec.whatwg.org/#creating-a-new-browsing-context

annevk · 2017-01-12T07:39:06Z

I saw someone mention that allowusermedia isn't implemented yet, so should we move that at the same time?

zcorpan · 2017-01-12T18:23:43Z

OK, done.

foolip

LGTM assuming that @domenic is happy with the nested var.

annevk · 2017-01-13T14:31:09Z

I was about to land this using

Snapshot allowpaymentrequest and allowusermedia attributes

New allow* attributes should use the snapshot model used by <iframe sandbox> and Feature Policy. The allowfullscreen attributes is left with its current live behavior in this change, because it is not yet clear if it is web-compatible to change it (see #2187).

Test: https://github.com/w3c/web-platform-tests/pull/4369.

Part of #2143.

as commit message however I noticed that the commit is no longer accurate.

annevk · 2017-01-13T14:32:04Z

source

+     possible this behavior will go away for the <code
+     data-x="attr-iframe-allowfullscreen">allowfullscreen</code> and <code
+     data-x="attr-iframe-allowusermedia">allowusermedia</code> attributes as well, see <a
+     href="https://github.com/whatwg/html/issues/2143#issuecomment-265514585">issue 2143</a>.</p>


We should remove allowusermedia from this message. I'll add a commit.

zcorpan · 2017-01-14T11:47:05Z

Thanks Anne. This is good to go now with your added commit?

annevk · 2017-01-14T16:54:10Z

Yeah, I didn't land it since I figured someone should review my change.

See whatwg/html#2195 (comment)

Test for whatwg/html#2195

zcorpan added the needs tests Moving the issue forward requires someone to write tests label Dec 20, 2016

zcorpan mentioned this pull request Dec 20, 2016

Snapshot allowfullscreen #2187

Closed

4 tasks

zcorpan added a commit to web-platform-tests/wpt that referenced this pull request Dec 20, 2016

Test snapshotting of allowpaymentrequest attribute

64e11f9

Test for whatwg/html#2195

zcorpan mentioned this pull request Dec 20, 2016

Test snapshotting of allowpaymentrequest attribute web-platform-tests/wpt#4369

Merged

zcorpan added a commit to web-platform-tests/wpt that referenced this pull request Dec 20, 2016

Test snapshotting of allowpaymentrequest attribute

6a242a7

Test for whatwg/html#2195

zcorpan removed the needs tests Moving the issue forward requires someone to write tests label Dec 20, 2016

zcorpan commented Dec 20, 2016

View reviewed changes

zcorpan added a commit to whatwg/resources.whatwg.org that referenced this pull request Dec 20, 2016

Add distinguishing style for <var><var>foo</var> flag</var>

b28db46

See whatwg/html#2195 (comment)

zcorpan mentioned this pull request Dec 20, 2016

Add distinguishing style for <var><var>foo</var> flag</var> whatwg/resources.whatwg.org#38

Merged

zcorpan requested a review from foolip December 21, 2016 08:50

zcorpan commented Dec 23, 2016

View reviewed changes

Actually set the flag on the document when it is created

edcbb1b

zcorpan mentioned this pull request Dec 27, 2016

Allow payment requests for same origin-domain subdocuments #2217

Merged

4 tasks

annevk mentioned this pull request Jan 11, 2017

Iframe sandboxing options for gUM w3c/mediacapture-main#268

Closed

Move allowusermedia to the snapshot model

fbfc90a

foolip approved these changes Jan 13, 2017

View reviewed changes

domenic approved these changes Jan 13, 2017

View reviewed changes

annevk reviewed Jan 13, 2017

View reviewed changes

simplify warning now allowusermedia is snapshotted

c602fe7

annevk merged commit b3224a8 into master Jan 14, 2017

annevk deleted the zcorpan/only-snapshot-allowpaymentrequest branch January 14, 2017 16:55

zcorpan added a commit to whatwg/resources.whatwg.org that referenced this pull request Jan 14, 2017

Add distinguishing style for <var><var>foo</var> flag</var>

2540dad

See whatwg/html#2195 (comment)

zcorpan added a commit to web-platform-tests/wpt that referenced this pull request Jan 19, 2017

Test snapshotting of allowpaymentrequest attribute

9a00e4a

Test for whatwg/html#2195

zcorpan mentioned this pull request Jan 25, 2017

Test <iframe allowusermedia> web-platform-tests/wpt#4625

Closed

zcorpan mentioned this pull request Aug 16, 2017

PaymentRequest: fixes allowpaymentrequest test errors web-platform-tests/wpt#6418

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Snapshot the allowpaymentrequest attribute #2195

Snapshot the allowpaymentrequest attribute #2195

zcorpan commented Dec 20, 2016

zcorpan commented Dec 20, 2016

zcorpan commented Dec 20, 2016

zcorpan Dec 20, 2016

domenic Dec 20, 2016

zcorpan Dec 20, 2016

domenic Dec 20, 2016

zcorpan Dec 20, 2016

zcorpan Dec 23, 2016 •

edited

Loading

annevk commented Jan 12, 2017

zcorpan commented Jan 12, 2017

foolip left a comment

annevk commented Jan 13, 2017

annevk Jan 13, 2017

zcorpan commented Jan 14, 2017

annevk commented Jan 14, 2017

Snapshot the allowpaymentrequest attribute #2195

Snapshot the allowpaymentrequest attribute #2195

Conversation

zcorpan commented Dec 20, 2016

zcorpan commented Dec 20, 2016

zcorpan commented Dec 20, 2016

zcorpan Dec 20, 2016

Choose a reason for hiding this comment

domenic Dec 20, 2016

Choose a reason for hiding this comment

zcorpan Dec 20, 2016

Choose a reason for hiding this comment

domenic Dec 20, 2016

Choose a reason for hiding this comment

zcorpan Dec 20, 2016

Choose a reason for hiding this comment

zcorpan Dec 23, 2016 • edited Loading

Choose a reason for hiding this comment

annevk commented Jan 12, 2017

zcorpan commented Jan 12, 2017

foolip left a comment

Choose a reason for hiding this comment

annevk commented Jan 13, 2017

annevk Jan 13, 2017

Choose a reason for hiding this comment

zcorpan commented Jan 14, 2017

annevk commented Jan 14, 2017

zcorpan Dec 23, 2016 •

edited

Loading