Clarify URL string spec reference #2318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The URL standard says "A URL is a universal identifier. To disambiguate from a URL string it can also be referred to as a URL record." So it's not correct to refer to this definition of "URL" for the validity requirements of an href attribute, which contains a string, not a record. I assume it was intended to refer to a "URL string", which is (more or less) the valid input to the URL parser.
|
This is a great fix, although we may want to wait on whatwg/url#228 in case we end up changing "URL string" to "valid URL string" or similar. |
|
I'm not sure how long that's going to take since the changes requested in that PR are rather elaborate. So I've gone ahead and merged this. |
|
Thanks @tstarling! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL standard says "A URL is a universal identifier. To disambiguate from a URL string it can also be referred to as a URL record." So it's not correct to refer to this definition of "URL" for the validity requirements of an href attribute, which contains a string, not a record. I assume it was intended to refer to a "URL string", which is (more or less) the valid input to the URL parser.