-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix : DOMStringMap is no more exposed to Worker #302
Conversation
For better or worse, the spec usually relies on the default exposure set, so you can remove If you can also link to https://www.w3.org/Bugs/Public/show_bug.cgi?id=28104 in the commit message and add your name to to the acknowledgements at the end of the spec, I'd be happy to merge this. |
Actually I have reviewed the source HTML, it has Exposed=Window at arount 7-8 places. So i asked @annevk. He said its better to remover Worker. Should I change again? |
The only other place where it's used "redundantly" is for Until we change the spec to always specify |
Ok. I'll remove it. |
It is the default exposure set for interfaces: http://heycam.github.io/webidl/#dfn-exposure-set See #302 (comment)
Dropped [Exposed = Window] for DOMStringMap |
I have added link to bug in the last commit message and added my name to the acknowledgement ! |
Thanks! I have squashed the commits into a single one and pushed as 1b4b0ef. Going forward, it's helpful if you have only one commit, updating it with |
It is the default exposure set for interfaces: http://heycam.github.io/webidl/#dfn-exposure-set See #302 (comment)
Sure. Will keep in mind. |
Thank you @PoojaSanklecha! |
No description provided.