Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make attribute order not matter for <progress> #3067

Merged
merged 1 commit into from
Oct 3, 2017
Merged

Make attribute order not matter for <progress> #3067

merged 1 commit into from
Oct 3, 2017

Conversation

annevk
Copy link
Member

@annevk annevk commented Sep 25, 2017

Fixes #3066.

annevk added a commit to web-platform-tests/wpt that referenced this pull request Sep 25, 2017
@annevk
HTML: <progress> and attribute order
9eb419c 
For whatwg/html#3067.
This was referenced Sep 25, 2017
Merged
Closed
foolip
foolip approved these changes Oct 3, 2017
View reviewed changes
Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading these diffs is pretty hard, but the crucial change around "parsed value" is in there.

@foolip foolip merged commit 6bf4f3c into master Oct 3, 2017
@foolip foolip deleted the annevk/progress branch October 3, 2017 22:35
foolip pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 3, 2017
@annevk @foolip
HTML: <progress> and attribute order
a2cb7ed 
For whatwg/html#3067.
@domenic
Copy link
Member

domenic commented Oct 3, 2017

Thanks for the review; I've been excited about getting this fixed and sad I wasn't able to tackle it.

@annevk, with your newfound expertise, would you be able to fix #2427 too?

jakearchibald pushed a commit to jakearchibald/web-platform-tests that referenced this pull request Nov 16, 2017
@annevk @jakearchibald
HTML: <progress> and attribute order
544d12d 
For whatwg/html#3067.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

Assignees

@foolip foolip

@domenic domenic

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annevk @domenic @foolip